#100 update backend #123
Merged
#100 update backend #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wim-De-Clercq
requested changes
Jun 14, 2024
README.md
Outdated
| with you objects as a service, it also decouples the storage | ||
| implementation from the interface. | ||
|
|
||
| ## Werken met pip-compile / pip-sync |
There was a problem hiding this comment.
Ik zou het engels laten aangezien dit een publieke package is en gans de wereld het in theorie kan gebruiken.
| def includeme(config): # pragma: no cover | ||
| beeldbank = Collection(name='cheeses', object_store=PairTreeFileSystemStore( | ||
| os.path.expanduser('~/data/cheeses/data'))) | ||
| def includeme(config): # pragma: no cover |
There was a problem hiding this comment.
nu we hier toch zitten, zou je beeldbank kunnen hernoemen naar cheeses, en besluiten naar trees
pyproject.toml
Outdated
| # In the wheel we want to have augeias in the root as python module. | ||
| only-include = [ | ||
| "/augeias", | ||
| "/fixtures", |
There was a problem hiding this comment.
fixtures niet nodig, wordt enkel gebruikt bij testen denk ik? Zou eigenlijk in tests folder mogen.
pyproject.toml
Outdated
| authors = [ | ||
| { name = "Flanders Heritage Agency", email = "[email protected]" }, | ||
| ] | ||
| description = "ugeias. Stores your files." |
Wim-De-Clercq
approved these changes
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.