This repository has been archived by the owner on Jul 13, 2018. It is now read-only.
navigation issue for android 4.4.4 and win 10 phone #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@masahirotanaka As @DidiYordanov reported in OnsenUI/OnsenUI#1449, this is a bug in Onsen UI for Microsoft Edge. The changes in this PR are a fix for that issue but I think we should fix it in the core library in case we want support for Microsoft Edge (I think we haven't agreed on that yet) instead of patching the templates. I guess for now we can keep this until we fix it in the core library, specially if this fix also works for Android versions. |
|
Yes, I know that this is a quick and dirty solution to make the templates work, and it is not a fix. We haven't agreed on having a full support on Edge, therefore our priority at the moment is just making the templates work among various platforms. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@masahirotanaka This is the change for the navigation template