docker/ci: fix rust installation #636
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PTAL |
|
This can be tested with |
bobg
reviewed
Mar 1, 2017
docker/ci/Dockerfile
Outdated
| && curl https://sh.rustup.rs -sSf | sh -s -- -y --default-toolchain nightly-2017-02-25 \ | ||
| && ~/.cargo/bin/cargo install rustfmt \ | ||
| && ~/.cargo/bin/cargo install clippy \ | ||
| && ~/.cargo/bin/cargo install cargo-audit \ |
There was a problem hiding this comment.
Remove trailing final backslash?
There was a problem hiding this comment.
I would actually prefer to keep the trailing backslash to try to make typos less likely in the future. If we're adding lines onto the end and we imitate the final line, it'll do the right thing instead of leaving off the backslash.
Also, even when we do the right thing, it reduces diff noise — it doesn't generate a spurious difference on the existing line just to add a backslash.
|
Adding in a couple more dependencies makes it get further, but it's still hung up on the following error: We can keep poking around at this, but if we can't figure it out in a day or two I think maybe we should back out the previous commit and look at other options. (Maybe switching to ubuntu as the base system?) |
|
This seems relevant... looks like they're using musl instead of glibc? gliderlabs/docker-alpine#168 Also: gliderlabs/docker-alpine#11 I'd think the happy path here would be to switch to Ubuntu. No worries if you want to back out this change until you do that. |
|
Yeah alpine is using musl for sure; and it looks like rust doesn't really play nice with musl. It would also be fine to run a static build of rust but it looks like such a thing isn't available. We tried installing a glibc alongside musl in the image, but haven't dug around in the rust build system enough to make sure it's picking up the glibc files instead of the musl files. |
|
Ok thank you! |
|
Looks like there's a project that supports building Rust with musl: |
|
If we end up migrating from Alpine, it seems like a good opportunity to use a CentOS based image. Most of our clients will be running RHEL. |
|
Yeah okay, it doesn't seem like a straightforward fix any more, so I'd like to back out 58c1cd0 for now, and then we can try again with either the musl-builder or CentOS. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.