Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STAC clarifications #291

Merged
merged 4 commits into from
Jun 30, 2020
Merged

STAC clarifications #291

merged 4 commits into from
Jun 30, 2020

Conversation

m-mohr
Copy link
Member

@m-mohr m-mohr commented Jun 12, 2020

  • Allow all STAC versions in range 0.9.x and 1.x.x for being more future proof. 0.9.0 and 1.x.x are vastly compatible and 1.x.x is not allowed to include braking changes anyway (SemVer followed by STAC).
  • Beforehand STAC was not clear how to specify unlocated Items, clarified that now that is has been clarified in STAC: Unlocated results set geometry to null and omit the bbox property (applies only to GET /jobs/{job_id}/results).
  • Formally forbid 5 elements in bounding boxes.
  • Clarify difference between STAC specification and STAC API.
  • Clarify that a copy of the STAC Item should be part of the assets in a batch job download.

This is backward-compatible with all back-ends, but may need some subtle changes in clients.

Related to:

@m-mohr m-mohr added the bug label Jun 12, 2020
@m-mohr m-mohr added this to the v1.0.0-final milestone Jun 12, 2020
@m-mohr m-mohr marked this pull request as draft June 16, 2020 14:19
@m-mohr m-mohr force-pushed the minMaxItems branch 2 times, most recently from 6f2135e to af6a151 Compare June 25, 2020 09:14
@m-mohr m-mohr marked this pull request as ready for review June 25, 2020 09:21
@m-mohr m-mohr changed the title Geometry/BBOX clarifications STAC clarifications Jun 25, 2020
Copy link
Member

@soxofaan soxofaan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine (apart from very minor notes)

@m-mohr
Copy link
Member Author

m-mohr commented Jun 29, 2020

Will merge on Wednesday, if no other comments come up.

@m-mohr
Copy link
Member Author

m-mohr commented Jun 30, 2020

Due to other demands, merging now. Got feedback from @flahn and @soxofaan and most changes (i.e. Item assets) are not relevant for the Hub or will be "fixed" through js-commons or vue-components, so should not be a problem.

@m-mohr m-mohr merged commit 3fd8724 into draft Jun 30, 2020
@m-mohr m-mohr deleted the minMaxItems branch June 30, 2020 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants