issue #693 add search for schema and find parameters from the backend #698
+102
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soxofaan
reviewed
Jan 6, 2025
There was a problem hiding this comment.
In this PR you add a lot of utility functions. A couple of notes on that:
- they are al public at the moment, so adding them adds the burden to keep/maintain/support them. In that sense, they should also get good test coverage.
- some of the seem quite tailored for the specific use case of this PR, while they are named very generically
also note that we already have parsing functionality for process definitions: e.g. see starting point openeo.internal.processes.Process.from_dict(). I think that should eliminate the need for all these new utility functions
I think it's also important that the core goal of this PR gets unit tests coverage
| "beta0", "sigma0-ellipsoid", "sigma0-terrain", "gamma0-ellipsoid", "gamma0-terrain", None | ||
| ] | ||
| schema = self.connection.get_schema("sar_backscatter", "coefficient") | ||
| coefficient_options = search_list_for_dict_key(schema, "enum") |
There was a problem hiding this comment.
There should be fallbacks for several situations:
- there is no connection (
self.connectionis None) - the backend does not provide an enum with possible coefficient values
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#693