Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[on-3141] unify colors #1034

Merged
merged 7 commits into from
Jan 7, 2025
Merged

Conversation

thehighestprimenumber
Copy link
Contributor

@thehighestprimenumber thehighestprimenumber commented Jan 3, 2025

Change the logic of the charts to grab the color assigned to each sector. Once we have the colors list from Design, we can use those.

Description by Korbit AI

What change is being made?

Unify color handling across the application by consolidating sector colors into a shared constant and updating components to use this new color schema.

Why are these changes being made?

These changes aim to maintain consistency in the color representation of sectors across different parts of the application, facilitating easier maintenance and updates to the color scheme. Centralizing color values in allSectorColors within the constants file reduces duplication and enhances readability.

Is this description stale? Ask me to generate a new description by commenting /korbit-generate-pr-description

Copy link

@korbit-ai korbit-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've completed my review and didn't find any issues... but I did find this squirrel.

         _.-"""-,
       .'  ..::. `\
      /  .::' `'` /
     / .::' .--.=;
     | ::' /  C ..\
     | :: |   \  _.)
      \ ':|   /  \
       '-, \./ \)\)
          `-|   );/
            '--'-'
Files scanned
File Path Reviewed
app/src/components/SegmentedProgress.tsx
app/src/app/[lng]/[inventory]/InventoryResultTab/EmissionBySectorChart.tsx
app/src/util/constants.ts
app/src/app/[lng]/[inventory]/InventoryResultTab/TopEmissionsWidget.tsx
app/src/components/HomePage/HomePage.tsx

Explore our documentation to understand the languages and file types we support and the files we ignore.

Need a new review? Comment /korbit-review on this PR and I'll review your latest changes.

Korbit Guide: Usage and Customization

Interacting with Korbit

  • You can manually ask Korbit to review your PR using the /korbit-review command in a comment at the root of your PR.
  • You can ask Korbit to generate a new PR description using the /korbit-generate-pr-description command in any comment on your PR.
  • Too many Korbit comments? I can resolve all my comment threads if you use the /korbit-resolve command in any comment on your PR.
  • Chat with Korbit on issues we post by tagging @korbit-ai in your reply.
  • Help train Korbit to improve your reviews by giving a 👍 or 👎 on the comments Korbit posts.

Customizing Korbit

  • Check out our docs on how you can make Korbit work best for you and your team.
  • Customize Korbit for your organization through the Korbit Console.

Current Korbit Configuration

General Settings
Setting Value
Review Schedule Automatic excluding drafts
Max Issue Count 10
Automatic PR Descriptions
Issue Categories
Category Enabled
Naming
Database Operations
Documentation
Logging
Error Handling
Systems and Environment
Objects and Data Structures
Readability and Maintainability
Asynchronous Processing
Design Patterns
Third-Party Libraries
Performance
Security
Functionality

Feedback and Support

Note

Korbit Pro is free for open source projects 🎉

Looking to add Korbit to your team? Get started with a free 2 week trial here

Copy link
Contributor

@cephaschapa cephaschapa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good overall we only need to change hard coded colors to use theme

app/src/components/HomePage/HomePage.tsx Outdated Show resolved Hide resolved
app/src/util/constants.ts Outdated Show resolved Hide resolved
app/src/util/constants.ts Outdated Show resolved Hide resolved
app/src/util/constants.ts Outdated Show resolved Hide resolved
app/src/util/constants.ts Outdated Show resolved Hide resolved
app/src/util/constants.ts Outdated Show resolved Hide resolved
@thehighestprimenumber thehighestprimenumber force-pushed the nina/feat/ON-3141/unifyColors branch from 5c54e7d to 00d395d Compare January 7, 2025 14:47
@thehighestprimenumber thehighestprimenumber merged commit 33a9c2c into develop Jan 7, 2025
2 of 3 checks passed
@thehighestprimenumber thehighestprimenumber deleted the nina/feat/ON-3141/unifyColors branch January 7, 2025 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants