-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ON-3099] add growth rate to tooltip #1046
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've completed my review and didn't find any issues... but I did find this dinosaur.
__
/ _)
.-^^^-/ /
__/ /
<__.|_|-|_|
Files scanned
File Path | Reviewed |
---|---|
app/src/backend/OpenClimateService.ts | ✅ |
app/src/components/SegmentedProgress.tsx | ✅ |
app/src/app/[lng]/[inventory]/InventoryResultTab/EmissionBySectorChart.tsx | ✅ |
app/src/app/[lng]/[inventory]/InventoryResultTab/TopEmissionsWidget.tsx | ✅ |
app/src/util/constants.ts | ✅ |
app/src/app/[lng]/[inventory]/InventoryResultTab/EmissionsForecast/EmissionsForecastChart.tsx | ✅ |
app/src/lib/app-theme.ts | ✅ |
Explore our documentation to understand the languages and file types we support and the files we ignore.
Need a new review? Comment
/korbit-review
on this PR and I'll review your latest changes.Korbit Guide: Usage and Customization
Interacting with Korbit
- You can manually ask Korbit to review your PR using the
/korbit-review
command in a comment at the root of your PR.- You can ask Korbit to generate a new PR description using the
/korbit-generate-pr-description
command in any comment on your PR.- Too many Korbit comments? I can resolve all my comment threads if you use the
/korbit-resolve
command in any comment on your PR.- Chat with Korbit on issues we post by tagging @korbit-ai in your reply.
- Help train Korbit to improve your reviews by giving a 👍 or 👎 on the comments Korbit posts.
Customizing Korbit
- Check out our docs on how you can make Korbit work best for you and your team.
- Customize Korbit for your organization through the Korbit Console.
Current Korbit Configuration
General Settings
Setting Value Review Schedule Automatic excluding drafts Max Issue Count 10 Automatic PR Descriptions ✅ Issue Categories
Category Enabled Naming ✅ Database Operations ✅ Documentation ✅ Logging ✅ Error Handling ✅ Systems and Environment ✅ Objects and Data Structures ✅ Readability and Maintainability ✅ Asynchronous Processing ✅ Design Patterns ✅ Third-Party Libraries ✅ Performance ✅ Security ✅ Functionality ✅ Feedback and Support
Note
Korbit Pro is free for open source projects 🎉
Looking to add Korbit to your team? Get started with a free 2 week trial here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This code looks OK. Some problems:
- you're not using semantic commit messages. Please get familiar with them and start using them. I use them for release management.
- It's also not clear why we have one PR for two different tickets.
- The tickets are pretty unclear as to what they do, and neither one is assigned to you.
None of these are blocking; I'll approve the merge.
Description by Korbit AI
What change is being made?
Enhance chart tooltips by adding growth rate information and consolidate color references by using a centralized color scheme.
Why are these changes being made?
The inclusion of growth rate data in the tooltips provides more detailed insights into emission trends over time, which is beneficial for data analysis and interpretation. Centralizing color references to use a unified
allSectorColors
array from constants ensures visual consistency across charts and simplifies color management.