Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mamba installation #1298

Closed
wants to merge 1 commit into from
Closed

Conversation

swsrkty
Copy link
Collaborator

@swsrkty swsrkty commented Nov 27, 2021

Fixes mamba failing to install MSS.

While installing MSS, the following error appears:

Encountered problems while solving.
Problem: nothing provides basemap 1.0.7 needed by mss-1.2.1-py27_0

This occurs because Mamba keeps python 3.10 unless explicitly mentioned, and currently we don't have a python 3.10 release.
Related: #613

@ReimarBauer
Copy link
Member

ReimarBauer commented Nov 27, 2021

Fixes mamba failing to install MSS.

While installing MSS, the following error appears:

Encountered problems while solving.
Problem: nothing provides basemap 1.0.7 needed by mss-1.2.1-py27_0

This occurs because Mamba keeps python 3.10 unless explicitly mentioned, and currently we don't have a python 3.10 release. Related: #613

not exactly but close ;)

someone implemented to use float comparison instead of version string comparison. It searches for python 3.1 not "3.10"

Copy link
Member

@ReimarBauer ReimarBauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please send a PR to stable. but bugreport first, we like to document before.

I will later merge stable to development.

@@ -33,8 +33,9 @@ Installing `MSS` from the `conda-forge` channel can be achieved by adding `conda

Once the `conda-forge` channel has been enabled, `mss` can be installed with:

$ conda create -n mssenv mamba
$ conda create -n mssenv python=3.9
Copy link
Member

@ReimarBauer ReimarBauer Nov 27, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove =3.9

seems there are more occurencies of this problem interpreting a version string as float number ;)

adding the python modul will release automatically the fixation and we will not need to adjust when we can use 3.10 again

Copy link
Member

@ReimarBauer ReimarBauer Nov 27, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and if "conda create -n mssenv mamba python" works we should do that

$ conda activate mssenv
$ conda install mamba
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this depends but will not cause trouble if you are using mambaforge

@swsrkty
Copy link
Collaborator Author

swsrkty commented Nov 30, 2021

Hi @ReimarBauer ,
I tried removing =3.9 and I also tried conda create -n mssenv mamba python, and neither of them worked.
When I ran the following, I didn't get any errors related to Python 3.1:

conda create -n mssenv python
conda activate mssenv
conda install mamba

Can you tell me which conda version are you using? Mine is 4.11.0. I think the error depends on the conda version.
I found out a bug on conda: conda/conda#10969, which could be responsibe for the error, but I didn't get that error.

I also wanted to ask: Isn't it good to specify the Python version while creating the conda environment? Related: mamba-org/mamba#1245.

I'll open the bug report issue and open the new PR once we come to a conclusion on the issue here. Is that alright?
Thank you! : )

@ReimarBauer
Copy link
Member

ReimarBauer commented Dec 2, 2021

We should always start with an issue before fixing something. Because all discussions are now hidden in the PR after it is merged/closed and it is quite difficult to reread or search for this.

When an issue gets added I could have labled it by 6.0.1 so it is clear that we want the fix in stable.

We link issues in the releases so everyone can find the PR.

A first issue could have been just the description of the problem. The PR afterwards brings the solution ;)

@ReimarBauer
Copy link
Member

I do also have the recent version and I tried the instructions from
https://mss.readthedocs.io/en/stable/installation.html#install

The version string is added on build time of the documentation. May be this can be done by an variable similiar in the README?

$ conda create -n mssenv mamba
$ conda activate mssenv
(mssenv) $ mamba install mss=6.0.0 python
(mssenv) $ mss

@ReimarBauer
Copy link
Member

We do build MSS for many python versions https://anaconda.org/conda-forge/mss/files

The fixation of the (most recent) python version is currently not mandatory for using MSS. Updating packages to a newer python version sometimes eats time. There can be an OS user which can't use a specified version of python because of some dependencies are not solved.

We came to the solution to force the version of MSS and let the system solve based on the fixations in the meta.yaml what the user can get.

@swsrkty
Copy link
Collaborator Author

swsrkty commented Dec 6, 2021

We should always start with an issue before fixing something. Because all discussions are now hidden in the PR after it is merged/closed and it is quite difficult to reread or search for this.
When an issue gets added I could have labled it by 6.0.1 so it is clear that we want the fix in stable.
We link issues in the releases so everyone can find the PR.
A first issue could have been just the description of the problem. The PR afterwards brings the solution ;)

Ah, got it. Thank you for explaining.
I've opened an issue and a PR #1301 for the same. Pls review it.

@swsrkty swsrkty closed this Dec 6, 2021
@swsrkty swsrkty deleted the fix_readme branch December 6, 2021 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants