-
-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PHP] New client generator php-dt #10041
Conversation
…ypes in DefaultGenerator - GlobalSettings usage mangled behaviour of other generators - fix of missing spaces in generated docs
I am at loss what to do with failing Maven plugin and Gradle plugin tests :[ PR does not touch them, error message from CI is a bit confusing and worst of all - build of poms for both plugins fails in my local development environment even if I take code from master. Could anyone please help to investigate these failed CI jobs? |
Please ignore those maven, gradle plugin issues as that happens with the master branch as well. |
@Articus thanks for the new generator. Looks good to me to include in the upcoming release to get feedback from our users. |
@wing328 is there any new generator policy, or just more == better? Do we need a generator in upstream that's build on top of library with 7 stars? |
@prochac , it seems you missed the main part - compliance with PSR-7, PSR-11, PSR-17 and PSR-18. "No hard feelings", but if these PHP standards mean nothing to you, maybe count stars for corresponding repositories - https://github.com/php-fig/http-message , https://github.com/php-fig/container , https://github.com/php-fig/http-factory , https://github.com/php-fig/http-client ? |
Added php-dt - new client generator for PHP language. Generated client is lightweight and extensible, relies on Data Transfer for handling request/response content and complies with PSR-7, PSR-11, PSR-17 and PSR-18.
This PR also makes
php-mezzio-ph
description in README.md up-to-date - I hope that is ok to make this micro update together with adding information about new generator.PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.For Windows users, please run the script in Git BASH.
master
,5.3.x
,6.0.x
cc @jebentier @dkarlovi @mandrean @jfastnacht @ackintosh @ybelenko @renepardon