Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[php-symfony] Allow non mandatory array value in Symfony #11618

Merged
merged 1 commit into from
May 26, 2022

Conversation

Cubid
Copy link
Contributor

@Cubid Cubid commented Feb 15, 2022

Hello,

We have an issue when a parameter is not set in a get query.
In file Service/JmsSerializer.php, the deserializeArrayString method does not check for null value.

If value is null, the returned data is an array with 1 element:

array(1) {
[0]=>
string(0) ""
}

This value the fails validation.

Returning null for a null input corrects the issue.

Mentionning contributors as requested:
@jebentier, @dkarlovi, @mandrean, @jfastnacht, @ackintosh, @ybelenko, @renepardon

@Cubid
Copy link
Contributor Author

Cubid commented Feb 16, 2022

Build is failing on Go language...
But there is no modification on Go!

@wing328
Copy link
Member

wing328 commented May 26, 2022

LGMT.

@wing328 wing328 merged commit fb1706b into OpenAPITools:master May 26, 2022
@wing328
Copy link
Member

wing328 commented May 26, 2022

@Cubid thanks for the PR, which has been merged.

Recently, we've updated the symfony generator to support Symfony 6. Please pull the latest master to give it a try.

@Cubid
Copy link
Contributor Author

Cubid commented May 30, 2022

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants