-
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[aspnetcore] Added parameter to generate models in a seperate csproj #13024
Conversation
@knom thanks for the PR. Can you please elaborate on the use case for this option? cc @mandrean (2017/08) @frankyjuang (2019/09) @shibayan (2020/02) @Blackclaws (2021/03) @lucamazzanti (2021/05) |
{ | ||
supportingFiles.add(new SupportingFile("ModelsProject.csproj.mustache", sourceFolder + File.separator + modelPackage, modelPackage + ".csproj")); | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you please update the Java code to conform the java code style? e.g.
if (...) {
// do something
} else {
// do something else
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine @wing328 I've refactored the IF/ELSEs
In C# some folks like to have MODELS in a seperate C# project from the CONTROLLERS and stuff. The new switch will generate 2 projects:
|
Thanks for the explanation. Let's give it a try. |
I guess we'd probably need special sample generators and CI test.. I tried to do that in #13044. |
@wing328
[aspnetcore] Added parameter to generate models in a seperate csproj
Now a seperate CSPROJ can be generated for MODELS.
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.For Windows users, please run the script in Git BASH.
master
(6.1.0) (minor release - breaking changes with fallbacks),7.0.x
(breaking changes without fallbacks)