Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flag Referenced Enum as Enum - Issue 5676 #13389

Closed

Conversation

rivancic
Copy link

@rivancic rivancic commented Sep 8, 2022

Fixes #5676
Referenced Enum is marked as Enum. There is additional flag on CodegenProperty#isInlineEnum that tells if enum is inline or referenced.

Sample Generation

At least one sample is failing to generate ATM.

Haskell issue

⚠️ Haskell sample project generation is failing. It has specific process for enums in HaskellHttpClientCodegen#toEnumName that throws NullPointerException when referenced schema isn't resolved.
I might add a unit test for it in HaskellHttpClientCodegenTest and try to fix it, while I would rather delegate this to someone more experienced with this part of logic in Haskell.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (6.1.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

riva and others added 2 commits September 8, 2022 15:56
- Add example OAS File
- Add DefaultCodegen container (array, map) tests
- Add SpringCodegenTest extension for multipart request - anyway it works ATM because of issues-12498
@wing328
Copy link
Member

wing328 commented Dec 28, 2022

closed via #13880

@wing328 wing328 closed this Dec 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CORE] Referenced Enums incorrectly tagged isEnum = false
2 participants