-
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Drop Python2 support and remove option "supportPython2" [python-flask][python-aiohttp][python-blueplanet] #13518
Conversation
Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/OpenAPITools/openapi-generator/graphs/contributors. Let me know if you need help fixing it. |
c7fd077
to
d0b54cc
Compare
[python-flask][python-aiohttp][python-blueplanet]
d0b54cc
to
09e6277
Compare
I now have linked my account with my gmail address. The PR is ready to merge |
CI tests failed:
ref: https://app.travis-ci.com/github/OpenAPITools/openapi-generator/builds/256245952 can you please take a look when you've time? Thanks. |
I downgraded pytest version from 7.1.0 to 7.0.1 to ensure compatibility with Python3.6. TravisCI is configured ( |
…hon3.6 [python-flask][python-aiohttp]
83d5343
to
9f47db2
Compare
Still failed: https://app.travis-ci.com/github/OpenAPITools/openapi-generator/builds/256269141 Is it correct to say that all python server samples have been tested locally with python 3.7 and works fine? If that' the case, I'll simply move these tests to CircleCI instead, which supports Python 3.7. |
I've filed #13585 to test these python server samples in CircleCI and so far the results are good after some minor fixes: https://app.circleci.com/pipelines/github/OpenAPITools/openapi-generator/19930/workflows/64cd9b94-4273-4ac1-9f98-b7bbc1823601 |
Closed via #13585 with all tests passed. Thanks again for the PR. |
As indicated into documentation (
docs/generators/python-flask.md
,docs/generators/python-aiohttp.md
,docs/generators/python-blueplanet.md
), Python2 support must be removed for these generators, normally for 5.x release. This PR do it and update generators with up-to-date dependenciesImpacted generators:
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.For Windows users, please run the script in Git BASH.
master
(6.1.0) (minor release - breaking changes with fallbacks),7.0.x
(breaking changes without fallbacks)@taxpon @frol @mbohlool @cbornet @kenjones-cisco @tomplus @spacether