Fix #13385 spring json nullable array #13537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rator into Issue13385-Spring-JsonNullable-Array
borsch
approved these changes
Sep 28, 2022
welshm
approved these changes
Sep 28, 2022
.../openapi-generator/src/test/java/org/openapitools/codegen/java/spring/SpringCodegenTest.java
Outdated
Show resolved
Hide resolved
...ore/spring-boot-nullable-set/src/main/java/org/openapitools/model/ObjectWithUniqueItems.java
Outdated
Show resolved
Hide resolved
jayandran-Sampath
pushed a commit
to jayandran-Sampath/openapi-generator
that referenced
this pull request
Oct 6, 2022
* Fixing to use equalsNullable when nullable set in config for SpringCodeGen * Adding additional test case file * removed print statement from SpringCodeGen * Updated model object * Corrected indentation and removed import * Fixed broken test * Updating sample
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated SpringCodeGen to handle nullable Arrays correctly. This fixes issue #13385.
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.For Windows users, please run the script in Git BASH.
master(6.1.0) (minor release - breaking changes with fallbacks),7.0.x(breaking changes without fallbacks)@cachescrubber @welshm @MelleD @atextor @manedev79 @javisst @borsch @banlevente @Zomzog
I'd love some advice on what is the correct branch to merge into for this change.
Contributed on behalf of the @opencastsoftware open source team. 👋