Gradle - make GenerateTask properties optional #2185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows easier creation of custom `GenerateTask`. Specifically, this makes: - generateModelTests - generateModelDocumentation - generateApiTests - generateApiDocumentation - withXml optional, following the same pattern as other properties in GenerateTask. Without this change, we get `java.lang.IllegalStateException: No value has been specified for this provider.` until these properties are specified for the task, when attempting to define a custom generate task (such as one to generate API docs).
kahowell
added a commit
to RedHatInsights/rhsm-conduit
that referenced
this pull request
Feb 18, 2019
These properties are supposed to be optional... but they are not. See related: OpenAPITools/openapi-generator#2185
|
@kahowell thanks for the PR. cc @jimschubert |
jimschubert
added a commit
that referenced
this pull request
Feb 23, 2019
* master: (40 commits) [Python] remove default value from being fallback to example (#2213) Add petstore integration tests to Ruby OAS3 client (#2211) Gradle - make GenerateTask properties optional (#2185) skip bats installation (#2198) Something in the dependencies changed. This switch is no longer needed. (#1850) Use oauth token for basic bearer auth in Rust. (#2161) Fix missing nullable (#2189) Enable error handling in Java WebClient library, fixes #1243 (#1244) [core] fix referenced enum case (#2175) rest-template: allow array parameters in path using collectionFormat (#2177) update go petstore samples Fix string types for cpprestsdk client generator (#1676) update kotline samples Remove API Key Authentication code for go when cookie is used. (#1601) changed the package install instructions to install the .tgz package … (#1989) okhttp-gson: allow array parameters in path using collectionFormat (#2137) [Ruby] Fix regualr expression in error message (#2069) (#2139) [kotlin][client] bytearray conversion (#2166) [rust-server] Added client documentation to rust-server (#2159) [Java] Getter/Setter naming convention not followed in generated models (#2095) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.sh,./bin/openapi3/{LANG}-petstore.sh,./bin/security/{LANG}-petstore.shand./bin/openapi3/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.master,. Default:3.4.x,4.0.xmaster.Description of the PR
This allows easier creation of custom
GenerateTask. Specifically, this makes:optional, following the same pattern as other properties in GenerateTask.
Without this change, we get
java.lang.IllegalStateException: No value has been specified for this provider.until these properties are specified for the task, when attempting to define a custom generate task (such as one to generate API docs).Note I left a couple of items in PR checklist unmarked as they don't seem relevant to this change. Please let me know if this should be handled differently.