Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[online] Honor GENERATOR_HOST env variable #3263

Merged
merged 1 commit into from
Jul 2, 2019
Merged

Conversation

jimschubert
Copy link
Member

@jimschubert jimschubert commented Jul 2, 2019

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.
  • Filed the PR against the correct branch: master, 4.1.x, 5.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

This sets "host" appropriately to the published host when GENERATOR_HOST
is configured.

This sets "host" appropriately to the published host when GENERATOR_HOST
is configured.
@auto-labeler
Copy link

auto-labeler bot commented Jul 2, 2019

👍 Thanks for opening this issue!
🏷 I have applied any labels matching special text in your issue.

The team will review the labels and make any necessary changes.

@jimschubert
Copy link
Member Author

@OpenAPITools/generator-core-team just FYI. Encountered this after adding Rapidoc, it looks like it was an issue before this as well but we were only forwarding to the api-doc JSON.

@jimschubert jimschubert merged commit b878068 into master Jul 2, 2019
@jimschubert jimschubert deleted the fix-api-doc-host branch July 2, 2019 13:15
@jimschubert
Copy link
Member Author

Found and issue, fixed in #3265

@cbornet
Copy link
Member

cbornet commented Jul 3, 2019

Springfox already has a springfox.documentation.swagger.v2.host to do that.
Otherwise it can detect the hostname from the request (respecting the x-forwarding-* headers) so forcing it to localhost by default is not correct.

@wing328 wing328 added this to the 4.1.0 milestone Aug 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants