Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Java][Rest-assured] Bump rest-assured version #3282

Merged
merged 3 commits into from
Jul 8, 2019

Conversation

viclovsky
Copy link
Contributor

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.
  • Filed the PR against the correct branch: master, 4.1.x, 5.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

Update rest-assured version to 4.0.0
@bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04)

@viclovsky
Copy link
Contributor Author

I just have noticed that models DogAllOf and CatAllOf are dissapered after running script ./bin/java-petstore-rest-assured.sh

@wing328
Copy link
Member

wing328 commented Jul 5, 2019

@viclovsky thanks for the PR.

Can you remove those tests as well?

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.6.1:testCompile (default-testCompile) on project petstore-rest-assured: Compilation failure: Compilation failure:
[ERROR] /home/circleci/OpenAPITools/openapi-generator/samples/client/petstore/java/rest-assured/src/test/java/org/openapitools/client/model/CatAllOfTest.java:[33,19] cannot find symbol
[ERROR] symbol:   class CatAllOf
[ERROR] location: class org.openapitools.client.model.CatAllOfTest
[ERROR] /home/circleci/OpenAPITools/openapi-generator/samples/client/petstore/java/rest-assured/src/test/java/org/openapitools/client/model/DogAllOfTest.java:[33,19] cannot find symbol
[ERROR] symbol:   class DogAllOf
[ERROR] location: class org.openapitools.client.model.DogAllOfTest
[ERROR] /home/circleci/OpenAPITools/openapi-generator/samples/client/petstore/java/rest-assured/src/test/java/org/openapitools/client/model/CatAllOfTest.java:[33,40] cannot find symbol
[ERROR] symbol:   class CatAllOf
[ERROR] location: class org.openapitools.client.model.CatAllOfTest
[ERROR] /home/circleci/OpenAPITools/openapi-generator/samples/client/petstore/java/rest-assured/src/test/java/org/openapitools/client/model/DogAllOfTest.java:[33,40] cannot find symbol
[ERROR] symbol:   class DogAllOf
[ERROR] location: class org.openapitools.client.model.DogAllOfTest

@viclovsky viclovsky force-pushed the rest-assured-4.0.0 branch from 143e064 to b52ad15 Compare July 5, 2019 16:45
@wing328 wing328 merged commit 0e37719 into OpenAPITools:master Jul 8, 2019
@wing328
Copy link
Member

wing328 commented Jul 8, 2019

Samples updated via 7cef5ed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants