[Java] fix javadoc configuration #3302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 Thanks for opening this issue! The team will review the labels and make any necessary changes. |
jmini
force-pushed
the
issue3299-javadoc-config
branch
from
8dd7e8e to
9ba5cf1
Compare
jmini
commented
Jul 8, 2019
| @@ -12,6 +12,7 @@ if [ "$NODE_INDEX" = "1" ]; then | |||
| #cp CI/pom.xml.circleci pom.xml | |||
| java -version | |||
| mvn --quiet verify -Psamples.circleci | |||
| mvn --quiet javadoc:javadoc -Psamples.circleci | |||
There was a problem hiding this comment.
Discussed with @wing328 on Gitter, this is a way to check that Javadoc can be built
wing328
approved these changes
Jul 8, 2019
wing328
changed the title
1 task
|
Not fixed for sbt.
Version 4.3.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3299.
The special javadoc tag
@http.response.detailsneeds to be declared correctly, so that the javadoc can be built.For maven, this PR changes where the
<configuration>block is added.It was inside the
<execution>bloc, but the example in the documetation (Configuring Custom Javadoc Tags) adds it directly in the<plugin>bloc.For gradle, the javadoc page do not really mention the
tagsoption, butGRADLE-1563 does. See also this question on stackoverflow.