[typescript-axios] @ts-ignore possible unused imports #3742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silasdavis
changed the title
|
Not sure how this pure text change to mustache templates could cause memory leak. |
|
Thanks for your pr |
Depending on the template parameters some imports may not get used - this causes a typescript compiler error that must be manually fixed. Signed-off-by: Silas Davis <[email protected]>
silasdavis
force-pushed
the
typescript-axios-unused-imports
branch
from
9230bd9 to
1101865
Compare
|
@macjohnny whoops, sorry about that, regenerated and rebased. also CC Typescript technical committee @TiFu (2017/07) @taxpon (2017/07) @sebastianhaas (2017/07) @kenisteward (2017/07) @Vrolijkx (2017/09) @macjohnny (2018/01) @nicokoenig (2018/09) @topce (2018/10) @akehir (2019/07) |
|
@silasdavis thanks for the PR, which has been included in the v4.1.2 release: https://twitter.com/oas_generator/status/1172068944355528705 |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depending on the template parameters some imports may not get used -
this causes a typescript compiler error that must be manually fixed.
fixes: #3743
Signed-off-by: Silas Davis [email protected]