Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[typescript-fetch] fix serialization/deserialization with inheritance #3767

Merged
merged 4 commits into from
Aug 28, 2019
Merged

[typescript-fetch] fix serialization/deserialization with inheritance #3767

merged 4 commits into from
Aug 28, 2019

Conversation

stephanpelikan
Copy link
Contributor

Fixes #3646
Also includes basic support of discriminators.

@macjohnny
Copy link
Member

thanks for your PR.
Please follow the steps in https://github.com/OpenAPITools/openapi-generator/blob/master/.github/PULL_REQUEST_TEMPLATE.md

@stephanpelikan
Copy link
Contributor Author

I've run ./bin/typescript-fetch-petstore.sh which succeeded. I've also with my application.

@TiFu @taxpon @sebastianhaas @kenisteward @Vrolijkx @macjohnny @nicokoenig @topce @akehir : Could you please review the PR.

Thanks in advance :-)

@macjohnny
Copy link
Member

I've run ./bin/typescript-fetch-petstore.sh which succeeded. I've also with my application.

please commit the files

@stephanpelikan
Copy link
Contributor Author

typescript-fetch-petstore.sh.log

@macjohnny
Copy link
Member

@stephanpelikan please commit and push the generated files in samples/client/petstore/typescript-fetch

@macjohnny macjohnny added this to the 4.1.2 milestone Aug 27, 2019
@macjohnny macjohnny changed the title #3646 - fix inheritence [typescript-fetch] fix serialization/deserialization with inheritance Aug 27, 2019
@stephanpelikan
Copy link
Contributor Author

please commit and push the generated files in samples/client/petstore/typescript-fetch

typescript-fetch-petstore.output.zip

@macjohnny macjohnny merged commit 28cf0b2 into OpenAPITools:master Aug 28, 2019
@wing328
Copy link
Member

wing328 commented Sep 12, 2019

@stephanpelikan thanks for the PR, which has been included in the v4.1.2 release: https://twitter.com/oas_generator/status/1172068944355528705

@stephanpelikan stephanpelikan deleted the bugfix/issue_3646 branch September 17, 2019 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@macjohnny macjohnny macjohnny approved these changes

Assignees
No one assigned
Labels
Client: TypeScript Feature: OAS 3.0 spec support Issue: Bug
Projects
None yet
Milestone
4.1.2
Development

Successfully merging this pull request may close these issues.

[BUG] [typescript-fetch] serialize/deserialze not working with inheritence
3 participants
@stephanpelikan @macjohnny @wing328