Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dart] Don't create redundant samples #3800

Merged

Conversation

nickmeinhold
Copy link
Contributor

@nickmeinhold nickmeinhold commented Aug 29, 2019

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.
  • Filed the PR against the correct branch: master, 4.1.x, 5.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

fixes #3799

  • removed lines in dart2-petstore.sh that create the redundant samples
  • deleted all dart2 samples
  • ran dart2-petstore.sh to create only openapi sample

- removed lines in dart2-petstore.sh that create redundant samples
- deleted all dart2 samples
- ran dart2-petstore.sh to create only openapi sample
@nickmeinhold nickmeinhold changed the title Don't create redundant samples [Dart] Don't create redundant samples Aug 30, 2019
Copy link
Member

@wing328 wing328 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wing328 wing328 merged commit f25c6da into OpenAPITools:master Aug 30, 2019
@wing328 wing328 added this to the 4.1.2 milestone Aug 30, 2019
@nickmeinhold nickmeinhold deleted the dart2-no-redundant-samples branch August 30, 2019 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[REQ] [Dart] Don't create redundant samples
2 participants