-
-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Java] Additional annotations for model type (class level annotations) #4026
Merged
jimschubert
merged 4 commits into
OpenAPITools:master
from
borsch:issue-4025-custom-java-annotations
Dec 3, 2019
Merged
[Java] Additional annotations for model type (class level annotations) #4026
jimschubert
merged 4 commits into
OpenAPITools:master
from
borsch:issue-4025-custom-java-annotations
Dec 3, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4dfca44
to
2dd5cfd
Compare
2dd5cfd
to
d4a6479
Compare
@wing328 @jimschubert could you please look at this? |
jimschubert
reviewed
Dec 2, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution. Just a few minor comments.
modules/openapi-generator/src/main/resources/Java/additionalModelTypeAnnotations.mustache
Outdated
Show resolved
Hide resolved
modules/openapi-generator/src/main/resources/JavaVertXWebServer/pojo.mustache
Outdated
Show resolved
Hide resolved
c358b65
to
c3150e5
Compare
jimschubert
approved these changes
Dec 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/
to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.sh
,./bin/openapi3/{LANG}-petstore.sh
if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\
. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.master
,4.1.x
,5.0.x
. Default:master
.Description of the PR
#4025
I want to have an ability to specify my custom annotations for model type. This will allow to add annotations from tools like
lombok
or in case if you have you customAnnotationProcessor
with own annotation