[Kotlin] enumPropertyNaming UPPERCASE should separate words with _

[lemoinem]

PR checklist

• Read the contribution guidelines.
• Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.
• Filed the PR against the correct branch: master, 4.1.x, 5.0.x. Default: master.
• Copied the technical committee to review the pull request if your PR is targeting a particular programming language.
  /cc Kotlin: @jimschubert @dr4ke616 @karismann @Zomzog

Description of the PR

When using enumPropertyNaming=UPPERCASE with the Kotlin generators, words aren't separated by _, as they should be.

[Fjolnir-Dvorak]

Could you please add a unit test for this that the next change in the code won't change it back again or does something else so it is documented how enums should be named?

[lemoinem]

@Fjolnir-Dvorak Sorry for the delay.
I've added some tests. Could you double check I did that correctly? I'm not sure if I need to do anything else.

CirleCI fails is related to "Docker Layer Caching is not available on your plan.". Not related to PR and looks like a configuration issue.

[Fjolnir-Dvorak]

yes, I will check that, thank you for that

[4brunu]

Any news on this PR? Looking forward to it 🙂

[Fjolnir-Dvorak]

Well, I didn't meant those tests but simple unit tests but I guess that works, too. Thank you for adding some tests

[lemoinem]

@Fjolnir-Dvorak Sorry, I looked at the existing tests I could see and didn't find how or where to add such unit tests. Any advice, is welcome... Where would the unit tests be in the code? Do you have any example of existing unit tests in the repo or any doc for it?

I did have a look at the content of openapi-generator/modules/openapi-generator/src/test/java/org/openapitools/codegen/kotlin/, but it seemed even more complex to setup and code than the one I added and seemed hardly readable or "simple" ;)...

[Fjolnir-Dvorak]

@lemoinem If you want I will look into it when this is merged. That test is not required. It is just nice to have those, especially because those "configurations" are easy to break by other people and are actually broken in many generators.
And since you made a golden test it is tested now which is all I asked for. Thank you for that.
But If you want to look into what exactly I had in mind you could look into org.openapitools.codegen.java.AbstractJavaCodegenTest. That one has exactly those cases tested.

[wing328]

Drone.io test failure already fixed in the master.