-
-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PHP] Preserve JSON accept header #4684
Conversation
modules/openapi-generator/src/main/resources/php/HeaderSelector.mustache
Outdated
Show resolved
Hide resolved
Hi @jorissteyn , i've updated the PR. In our case
I had to modify the regex to match |
@wing328 same here :) switched to master. |
@ro0NL thanks for the PR. Can you reuse the following regular expression to detect JSON MIME instead? public boolean isJsonMime(String mime) {
String jsonMime = "(?i)^(application/json|[^;/ \t]+/[^;/ \t]+[+]json)[ \t]*(;.*)?$";
return mime != null && (mime.matches(jsonMime) || mime.equals("*/*"));
} These are Java code and we need to plot the regular expression to PHP. Ref: Line 514 in d75d089
|
@wing328 done :) https://3v4l.org/TkPqE |
modules/openapi-generator/src/main/resources/php/HeaderSelector.mustache
Show resolved
Hide resolved
cc @jebentier (2017/07), @dkarlovi (2017/07), @mandrean (2017/08), @jfastnacht (2017/09), @ackintosh (2017/09) ❤️, @ybelenko (2018/07), @renepardon (2018/12) |
Welcome @ro0NL, nice to have you here. 💯 |
fixes #4636 (comment)
PR checklist
./bin/
(or Windows batch scripts under.\bin\windows
) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run./bin/{LANG}-petstore.sh
,./bin/openapi3/{LANG}-petstore.sh
if updating the code or mustache templates for a language ({LANG}
) (e.g. php, ruby, python, etc).master
,4.3.x
,5.0.x
. Default:master
.