[Slim4] Data mocker for scalar types #4751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've reconsidered. Small PR will be easier to review. Let's keep this PR with scalar types only, I think it's a good starting point. I'll work on other types in local branch and submit when this will be merged. |
ybelenko
force-pushed
the
slim_data_mocker
branch
from
c604c32 to
1401ed0
Compare
How to test
$ git checkout -b ybelenko-slim_data_mocker master
$ git pull https://github.com/ybelenko/openapi-generator.git slim_data_mocker
$ mvn clean package
$ bin/php-slim4-server-petstore.sh
$ cd samples/server/petstore/php-slim4
$ composer install
$ composer test
$ composer phpcs |
I've rejected the idea to keep Composer dependencies in Java/codegen variables at some point of time. It seems that after Git rebase I forgot to delete them.
ybelenko
force-pushed
the
slim_data_mocker
branch
from
1401ed0 to
164a7a0
Compare
ybelenko
commented
Dec 14, 2019
samples/server/petstore/php-slim4/lib/Mock/OpenApiDataMockerInterface.php
Show resolved
Hide resolved
wing328
approved these changes
Dec 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/(or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run./bin/{LANG}-petstore.sh,./bin/openapi3/{LANG}-petstore.shif updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).master,4.3.x,5.0.x. Default:master.I'm working on mock server for Slim generator. Maybe my
OpenApiDataMockerInterfacecan be useful in other PHP generators. Right now only scalar data types implemented.arrayandobjectare coming next. Then I'll addenumoption tomockStringand methodmockSchemato generate data from spec schema object.Related to #3545
cc @jebentier, @dkarlovi, @mandrean, @jfastnacht, @ackintosh, @renepardon