[kotlin][client] unify jvm libraries #4827
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initially kotlin only supported the libraries jvm (with okhttp) and Multiplatform.
Now it supports one extra jvm library that is retrofit2.
So the options are jvm-okhttp4 (default), jvm-okhttp3, retrofit2 (also jvm), Multiplatform.
I think that for consistency in the name the retrofit2 should be called jvm-retrofit2.
And in the future all the libraries should respect jvm-* or Multiplatform-*.
This PR also reuses unifies jvm code to avoid duplication by introducing a directory called ivm-common.
One last thing is that by default the Gson serialiser already has UUID support out of the box, so I removed it in the Gson and keep it in Moshi.
PR checklist
./bin/
(or Windows batch scripts under.\bin\windows
) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run./bin/{LANG}-petstore.sh
,./bin/openapi3/{LANG}-petstore.sh
if updating the code or mustache templates for a language ({LANG}
) (e.g. php, ruby, python, etc).master
,4.3.x
,5.0.x
. Default:master
.@jimschubert (2017/09) ❤️, @dr4ke616 (2018/08) @karismann (2019/03) @Zomzog (2019/04) @andrewemery (2019/10) @4brunu (2019/11)