Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kotlin][client] unify jvm libraries #4827

Merged
merged 9 commits into from
Dec 20, 2019

Conversation

4brunu
Copy link
Contributor

@4brunu 4brunu commented Dec 18, 2019

Initially kotlin only supported the libraries jvm (with okhttp) and Multiplatform.
Now it supports one extra jvm library that is retrofit2.
So the options are jvm-okhttp4 (default), jvm-okhttp3, retrofit2 (also jvm), Multiplatform.
I think that for consistency in the name the retrofit2 should be called jvm-retrofit2.
And in the future all the libraries should respect jvm-* or Multiplatform-*.

This PR also reuses unifies jvm code to avoid duplication by introducing a directory called ivm-common.

One last thing is that by default the Gson serialiser already has UUID support out of the box, so I removed it in the Gson and keep it in Moshi.

PR checklist

  • Read the contribution guidelines.
  • If contributing template-only or documentation-only changes which will change sample output, build the project before.
  • Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
  • File the PR against the correct branch: master, 4.3.x, 5.0.x. Default: master.
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@jimschubert (2017/09) ❤️, @dr4ke616 (2018/08) @karismann (2019/03) @Zomzog (2019/04) @andrewemery (2019/10) @4brunu (2019/11)

@auto-labeler
Copy link

auto-labeler bot commented Dec 18, 2019

👍 Thanks for opening this issue!
🏷 I have applied any labels matching special text in your issue.

The team will review the labels and make any necessary changes.

@wing328 wing328 added this to the 4.2.3 milestone Dec 20, 2019
@wing328 wing328 merged commit 56f298a into OpenAPITools:master Dec 20, 2019
@4brunu 4brunu deleted the feature/kotlin_unify_jvm branch January 2, 2020 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants