Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[asciidoc] add option to not generate metadata #4852

Conversation

man-at-home
Copy link
Contributor

@man-at-home man-at-home commented Dec 20, 2019

add a new cli option (additionalParameter): generateHeaders for asciidoc generator. If set to false suppress generation of attributes in the markup header section.

PR checklist

  • Read the contribution guidelines.
  • If contributing template-only or documentation-only changes which will change sample output, build the project before.
  • Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix.
  • File the PR against the [correct branch] master
  • Copy the [technical committee] to review the pull request if your PR is targeting a particular programming language.

@wing328 @jimschubert @cbornet @ackintosh @jmini @etherealjoy

==> please view the boolean command line option, I had to change the type from string to booelan
within the generator, otherweise the mustache templates would not work. Are boolean command line options possible?

issue by @mgwoj

For #4848

…iidoc attributes)

cli / additionalParameters: generateHeaders=true|false
…iidoc attributes)

cli / additionalParameters: generateHeaders=true|false
@man-at-home man-at-home changed the title (WIP) #4848 [asciidoc] add option to not generate metadata #4848 [asciidoc] add option to not generate metadata Dec 21, 2019
@man-at-home
Copy link
Contributor Author

working pr.

code questionable: change cli string property to boolean:

        this.additionalProperties.put(HEADER_ATTRIBUTES_FLAG,  "TRUE".equalsIgnoreCase(headerAttributesFlagValue)); // change attribute in map to type boolean.

@wing328
Copy link
Member

wing328 commented Dec 22, 2019

code questionable: change cli string property to boolean:

I'll fix the boolean option in another PR.

@wing328 wing328 merged commit c0994c4 into OpenAPITools:master Dec 22, 2019
@wing328 wing328 changed the title #4848 [asciidoc] add option to not generate metadata [asciidoc] add option to not generate metadata Dec 22, 2019
@wing328 wing328 added this to the 4.2.3 milestone Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants