Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[typescript-axios] Fixed call of toISOString on a string type when using string type-mapping #5057

Merged
merged 1 commit into from
Jan 20, 2020
Merged

[typescript-axios] Fixed call of toISOString on a string type when using string type-mapping #5057

merged 1 commit into from
Jan 20, 2020

Conversation

LiamMartens
Copy link
Contributor

@TiFu @taxpon @sebastianhaas @kenisteward @Vrolijkx @macjohnny @nicokoenig @topce @akehir @petejohansonxo

Created a detailed repro repository here

Basic gist of it is the following, let's assume you have following swagger definition

"parameters": [
    {
        "name": "param",
        "in": "query",
        "required": false,
        "type": "string",
        "format": "date-time"
    }
],

When type mapping date to string this results in the following generated code

example(param?: string, options: any = {}): RequestArgs {
    ....
    if (param !== undefined) {
        localVarQueryParameter['param'] = (param as any).toISOString(); <-- toISOString() on string type
    }
    ...
},

This same fix was applied to the isDate template.

PR checklist

  • [x ] Read the contribution guidelines.
  • [ x] If contributing template-only or documentation-only changes which will change sample output, build the project before.
  • [x ] Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
  • [x ] File the PR against the correct branch: master, 4.3.x, 5.0.x. Default: master.
  • [x ] Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@auto-labeler
Copy link

auto-labeler bot commented Jan 20, 2020

👍 Thanks for opening this issue!
🏷 I have applied any labels matching special text in your issue.

The team will review the labels and make any necessary changes.

@macjohnny macjohnny added this to the 4.2.3 milestone Jan 20, 2020
@macjohnny macjohnny merged commit 7599531 into OpenAPITools:master Jan 20, 2020
@wing328 wing328 changed the title [typescript-axios] Fixed call of toISOString on a string type when using string type-map… [typescript-axios] Fixed call of toISOString on a string type when using string type-mapping Jan 31, 2020
maccuaa added a commit to maccuaa/intellitrust-js-sdk that referenced this pull request Feb 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants