Implement Asp.Net Core 3.0/3.1 generator (#6009) #6025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The build failures don't appear to be anything to do with the code changes, do I need to base this off a different commit? |
|
I've updated the documentation via fff4da9. Let's see how it goes. |
|
cc @A-Joshi as well. |
|
Seems like the Swift4 tests are the culprit now |
shibayan
suggested changes
Apr 28, 2020
modules/openapi-generator/src/main/resources/aspnetcore/3.0/Startup.mustache
Outdated
Show resolved
Hide resolved
modules/openapi-generator/src/main/resources/aspnetcore/3.0/Startup.mustache
Outdated
Show resolved
Hide resolved
| @@ -0,0 +1,9 @@ | |||
| <?xml version="1.0" encoding="utf-8"?> | |||
There was a problem hiding this comment.
Should I remove the entire www directory as that's not part of the template anymore?
There was a problem hiding this comment.
Yes. It should be fine to remove it.
…artup.mustache Co-Authored-By: Tatsuro Shibamura <[email protected]>
…artup.mustache Co-Authored-By: Tatsuro Shibamura <[email protected]>
wing328
reviewed
May 1, 2020
modules/openapi-generator/src/main/resources/aspnetcore/2.1/Startup.mustache
Show resolved
Hide resolved
|
If no further feedback, I'll merge this over the weekend. |
|
Please wait for the merge until web.config under wwwroot is removed. That setting is harmful. |
|
@shibayan no worry. I'll remove it after merging the PR into master |
|
Filed #6147 to skip web.config generation. |
5 tasks
|
@phatcher thanks for the PR, which has been included in the v4.3.1 release: https://twitter.com/oas_generator/status/1258057660974329861 |
michaelpro1
pushed a commit
to michaelpro1/openapi-generator
that referenced
this pull request
May 7, 2020
…Tools#6025) * Minor changes to 2.1 templates to make them work or improve documentation * Support for ASP.NET Core 3.0 and 3.1 * Update aspnetcore test scripts and results * Update generated documentation * update doc * Update modules/openapi-generator/src/main/resources/aspnetcore/3.0/Startup.mustache Co-Authored-By: Tatsuro Shibamura <[email protected]> * Update modules/openapi-generator/src/main/resources/aspnetcore/3.0/Startup.mustache Co-Authored-By: Tatsuro Shibamura <[email protected]> Co-authored-by: William Cheng <[email protected]> Co-authored-by: Tatsuro Shibamura <[email protected]>
jimschubert
added a commit
that referenced
this pull request
May 8, 2020
…-5.0 * origin/master: (78 commits) [powershell-experimental] : http signature authentication implementation (#6176) Add missing AnyType type mapping (#6196) remove pubspec.lock (#6208) Minor fixes post-release (#6204) [cpp][Qt5] Add the ability to pass QNetworkAccessManager as a parameter (#6053) comment out dart2 test due to failure adds the missing typeMapping for AnyType (#6199) [Rust Server] Support boolean headers, and fix panic handling headers (#6056) update samples update 5.0.0 release date update readme with new release Prepare 4.3.1 release (#6187) Fix #6157: Updated native template to fix null async return (#6168) Show description when summary is missing (#6159) Make the array items optional (#6132) [aspnetcore] test petstore samples in drone.io (#6148) fix bearer auth in c# netcore async call (#6136) skip web.config for aspnetcore 3.x (#6147) Adds memoization and deserialization through 2 or more discriminators (#6124) Implement Asp.Net Core 3.0/3.1 generator (#6009) (#6025) ...
MikailBag
pushed a commit
to MikailBag/openapi-generator
that referenced
this pull request
May 31, 2020
…Tools#6025) * Minor changes to 2.1 templates to make them work or improve documentation * Support for ASP.NET Core 3.0 and 3.1 * Update aspnetcore test scripts and results * Update generated documentation * update doc * Update modules/openapi-generator/src/main/resources/aspnetcore/3.0/Startup.mustache Co-Authored-By: Tatsuro Shibamura <[email protected]> * Update modules/openapi-generator/src/main/resources/aspnetcore/3.0/Startup.mustache Co-Authored-By: Tatsuro Shibamura <[email protected]> Co-authored-by: William Cheng <[email protected]> Co-authored-by: Tatsuro Shibamura <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #6009, mainly new templates but some minor changes to the aspnetcore generator:
PR checklist
./bin/(or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run./bin/{LANG}-petstore.sh,./bin/openapi3/{LANG}-petstore.shif updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).master,4.3.x,5.0.x. Default:master.