[Java][jersey2] Fix serializeToString
#6956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wing328
changed the title
serializetostringserializeToString
|
Fix for #6954 |
.../client/petstore/java/jersey2-java8/src/test/java/org/openapitools/client/ApiClientTest.java
Outdated
Show resolved
Hide resolved
.../client/petstore/java/jersey2-java8/src/test/java/org/openapitools/client/ApiClientTest.java
Outdated
Show resolved
Hide resolved
| // nulllable and there should be no diffencne as the payload is not null | ||
| assertEquals(result, apiClient.serializeToString(pet, null, "application/json", true)); | ||
|
|
||
| // non-nullable null object should give "" (empty body) |
There was a problem hiding this comment.
I think this use case is non trivial to understand because there may be two variants:
- The request is supposed to have an empty body by design, i.e. the OpenAPI doc request or response schema indicates the body is empty.
- The client or server is setting the data incorrectly. I.e. the OpenAPI doc indicates the object is not nullable, but the actually either the client or server are setting to a null value.
Is it even possible?
There was a problem hiding this comment.
The client or server is setting the data incorrectly
This can be prevented by marking the "body" parameter (OAS v2 term) as required.
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To fix #6954
PR checklist
./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example./bin/generate-samples.sh bin/config/java*. For Windows users, please run the script in Git BASH.mastercc @bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10) @bkabrda (2020/01)