Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dart (Jaguar) client generator #998

Merged
merged 10 commits into from
Sep 13, 2018
Merged

Dart (Jaguar) client generator #998

merged 10 commits into from
Sep 13, 2018

Conversation

wing328
Copy link
Member

@wing328 wing328 commented Sep 8, 2018

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.3.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

As discussed with @jaumard, I've cherry-picked his commit (a1e50a6) to add Dart (Jaguar) client generator to this project (OpenAPI Generator)

@wing328 wing328 added this to the 3.3.0 milestone Sep 8, 2018
@wing328
Copy link
Member Author

wing328 commented Sep 10, 2018

@jaumard as requested, I've cherry-picked 2fbf92e4d9d119750e6407a40e4fc02a792506ef into this PR (after resolving the merge conflicts)

@wing328
Copy link
Member Author

wing328 commented Sep 11, 2018

Merged #1009 into this branch.

@wing328
Copy link
Member Author

wing328 commented Sep 11, 2018

cc @ircecho @swipesight for review

@wing328 wing328 removed the WIP Work in Progress label Sep 11, 2018
@wing328 wing328 changed the title [WIP] Dart (Jaguar) client generator Dart (Jaguar) client generator Sep 11, 2018
@jaumard
Copy link
Contributor

jaumard commented Sep 11, 2018

Just notice a bug in Jaguar, need to fix and update the deps in this PR, should be done today and doesn't change the rest of the PR. Just dependency bump

@wing328
Copy link
Member Author

wing328 commented Sep 12, 2018

@jaumard I've updated the pom to include the following in the Travis CI build:

                <module>samples/client/petstore/dart-jaguar/openapi</module>
                <module>samples/client/petstore/dart-jaguar/flutter_petstore/openapi</module>

The good thing is that the build is green and I'm able to trigger a failure by manually breaking the code.

@jaumard
Copy link
Contributor

jaumard commented Sep 12, 2018

Nice !!! So I didn't do that much shit :p lol

@wing328
Copy link
Member Author

wing328 commented Sep 12, 2018

@jaumard thanks for your awesome contribution.

If no question from @ircecho @swipesight , I'll merge it into master tomorrow.

@wing328 wing328 merged commit 29322da into master Sep 13, 2018
@wing328 wing328 deleted the dart-jaguar branch September 13, 2018 13:40
@wing328
Copy link
Member Author

wing328 commented Sep 13, 2018

@jaumard thanks for the PR, which has been merged into master.

We'll send out a tweet to promote the new generator and tag your twitter account (https://twitter.com/jaumard)

@jaumard
Copy link
Contributor

jaumard commented Sep 13, 2018

No problem ! Thanks a lot for your help on this !

@wing328
Copy link
Member Author

wing328 commented Sep 14, 2018

Tweet: https://twitter.com/oas_generator/status/1040537944296046592

Please retweet to help promote the new generator

jaumard pushed a commit to jaumard/openapi-generator that referenced this pull request Sep 21, 2018
@wing328 @jaumard
Dart (Jaguar) client generator (OpenAPITools#998)
e9f68ca 
* generator for dart jaguar

* migrate to openapi-generator

* fix locale issue

* add auth generation for dart jaguar

* fix generation of jaguar api with auth (OpenAPITools#1009)

* update deps (OpenAPITools#1016)

* add CI tests for dart jaguar

* update dart jaguar bin script

* trigger build failure

* Revert "trigger build failure"

This reverts commit a7d8bfd.
A-Joshi pushed a commit to ihsmarkitoss/openapi-generator that referenced this pull request Feb 27, 2019
@wing328
Dart (Jaguar) client generator (OpenAPITools#998)
639681a 
* generator for dart jaguar

* migrate to openapi-generator

* fix locale issue

* add auth generation for dart jaguar

* fix generation of jaguar api with auth (OpenAPITools#1009)

* update deps (OpenAPITools#1016)

* add CI tests for dart jaguar

* update dart jaguar bin script

* trigger build failure

* Revert "trigger build failure"

This reverts commit a7d8bfd.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Client: Dart Enhancement: New generator
Projects
None yet
Milestone
3.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@wing328 @jaumard