Add Bal Library Url expansion variable #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feltech
requested changes
Apr 9, 2024
tests/resources/library_business_logic_suite_var_expansion.json
Outdated
Show resolved
Hide resolved
feltech
approved these changes
Apr 11, 2024
Issue OpenAssetIO#86 Similar to the current $bal_library_dir behaviour, add a bal_library_dir_url which expands to a file url of the directory the library is in. Due to the desire to allow relative paths, we now invoke normalization behaviour on substitutions depending on if the entire string is a file url, ie, does it start with "file:". These substitutions are compatible with openassetio url conversion methods. Signed-off-by: Elliot Morris <[email protected]>
Now that OpenAssetIO v1.0.0-beta2.1 is released, we can once again depend on the PyPI packages Signed-off-by: Elliot Morris <[email protected]>
elliotcmorris
force-pushed
the
work/86-bal-library-url
branch
from
62a883f to
e741fb5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#86
Add Bal Library Url expansion variable.
Perform path normalization on any path that begins with "File:"
The intent of this is so folks can take BAL locations and use them in the path/url converters openassetio provides.
This path stuff boggles me a bit, i'm not sure if the testing is sufficient.