Add entityTraits support #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
feltech
force-pushed
the
work/89-entityTraits
branch
from
d19146b to
afec031
Compare
elliotcmorris
approved these changes
Dec 1, 2023
foundrytom
approved these changes
Dec 1, 2023
feltech
force-pushed
the
work/89-entityTraits
branch
3 times, most recently
from
921b7af to
db143b6
Compare
feltech
force-pushed
the
work/89-entityTraits
branch
from
db143b6 to
35d19e4
Compare
foundrytom
approved these changes
Dec 8, 2023
Closes OpenAssetIO#89. The `entityTraits` API method is a new required method. For reading, return the traits of the entity, plus the implicit VersionTrait. For write, return the traits of the entity, but don't include the VersionTrait (since it cannot be written directly). The implementation assumes new entities have no restriction on the traits that can be published to them; whereas new versions of existing entities are restricted to the same trait set as previous versions. This latter case is not actually enforced during `preflight`/`register`. See OpenAssetIO#92. Signed-off-by: David Feltell <[email protected]>
Part of OpenAssetIO#89. Until the next OpenAssetIO release, we must once again use wheels built from the main branch, and cannot have a package dependency on the unreleased version. Signed-off-by: David Feltell <[email protected]>
feltech
force-pushed
the
work/89-entityTraits
branch
from
27fe84e to
cdf18c1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #89. The
entityTraitsAPI method is a new required method.