-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use micromamba #123
use micromamba #123
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Just one question about the conda channel. Also, I think the changes to test_tox.yml
and tox.ini
should be reverted. I added tests with the con_da
tox environment is for testing that conda can be configured via an Actions input, and not just through the environment name. (The tests for this project are quite confusing!)
c6e5193
to
a9c8d9b
Compare
I think the Maybe we should be avoiding Also, I this silent error looks like we might need to update the |
5f01b7a
to
67f11b9
Compare
63173f0
to
7e112b7
Compare
@ConorMacBride sorry it took me so long to get back to this! The tests appear to be passing now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me but I will let @ConorMacBride have the final word.
Thanks @zacharyburnett !
649f674
to
d5584de
Compare
not to rush anyone; this is ready to merge and fixes the failing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @zacharyburnett! Sorry for the delay in reviewing
fixes #197 I think?