Default to arm64 builders for macos wheels and cross compile x86_64 by default #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
oh lol it seems like it's quicker to build x86_64 macos wheels on arm64 than it is on the native x86_64 macos-13 runners. |
astrofrog
approved these changes
Dec 5, 2024
Cadair
force-pushed
the
macos_arm64_cross
branch
from
170cb37 to
e140092
Compare
Cadair
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This effectively reverts #195 and #186 and moves us to arm64 macos by default. (Using #247 it's techincally now possible to force a macos-13 native build for x86_64).
This fixes #256 which is the removal of macos-12.