Upgrade passport saml to 5.x

[aHenryJard]

Description

Despite green CI upgrade to 0.9.2 is breaking at least SAML authentication. Some code changes are required for upgrade.

see b35c33c

Error message is

"errorHandler object is no longer supported, switch to onError!"

Passport saml is related see #8064

Environment

1. OS (where OpenCTI server runs): { e.g. Mac OS 10, Windows 10, Ubuntu 16.4, etc. }
2. OpenCTI version: { e.g. OpenCTI 1.0.2 }
3. OpenCTI client: { e.g. frontend or python }
4. Other environment details:

SAML Authentication at least.

Reproducible Steps

Steps to create the smallest reproducible scenario:

1. { e.g. Run ... }
2. { e.g. Click ... }
3. { e.g. Error ... }

Expected Output

Actual Output

Additional information

Screenshots (optional)

[SamuelHassine]

@aHenryJard This one can help I think: #8064.

[aHenryJard]

@aHenryJard This one can help I think: #8064.

Yes I think that we need to do both at the same time.

[aHenryJard]

update: actually updating passport-saml to 5.0.0 is not enough, @nodesaml/nodesaml 5.0.0 is still not compatible with @xmldom/xmldom 0.9.+. Need to stick on 0.8.10 for now.

[aHenryJard]

Merged on 6.4 release branch for passport-saml 5, xmldom still must be done be can't in current version of passport-saml

[nino-filigran]

@aHenryJard So can we close the ticket?

[aHenryJard]

@nino-filigran it's on 6.4 release branch