Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] reset local storage from user profile (#9572) #9589

Open
wants to merge 4 commits into
base: release/6.5.0
Choose a base branch
from

Conversation

labo-flg
Copy link
Member

@labo-flg labo-flg commented Jan 14, 2025

Proposed changes

  • new section in user profile view, with a button to clear the local storage.

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case (coverage and e2e)
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

@labo-flg labo-flg force-pushed the issue/9572-reset-local-storage branch 2 times, most recently from a8dd0da to b6b9102 Compare January 14, 2025 15:22
@labo-flg labo-flg force-pushed the issue/9572-reset-local-storage branch from b6b9102 to 40e94af Compare January 14, 2025 16:51
Copy link

codecov bot commented Jan 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.53%. Comparing base (4bdae16) to head (97f09dd).
Report is 4 commits behind head on release/6.5.0.

Additional details and impacted files
@@                Coverage Diff                @@
##           release/6.5.0    #9589      +/-   ##
=================================================
+ Coverage          65.23%   65.53%   +0.30%     
=================================================
  Files                636      637       +1     
  Lines              60931    62149    +1218     
  Branches            6841     7717     +876     
=================================================
+ Hits               39747    40732     +985     
- Misses             21184    21417     +233     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CelineSebe CelineSebe self-requested a review January 15, 2025 07:52
@CelineSebe
Copy link
Member

image

A translation error on "local"

sx={{ color: 'text.primary' }}
>
<AlertTitle style={{ marginBottom: 0, fontWeight: 400 }}>
{t_i18n('This will erase all the views settings you have made. All these changes will be lost. Are you sure?')}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a blocker but

Suggested change
{t_i18n('This will erase all the views settings you have made. All these changes will be lost. Are you sure?')}
{t_i18n('This will erase all the views settings that you have made. All these changes will be lost. Are you sure?')}

I thing it's either "you made" or "that you have made"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants