Remove stropping and encoding prefix from filter args. Make these global options #94
Labels
Milestone
Comments
thirtytwobits
added
bug
|
Actually, remove "stropping:bool" as well and make this global. |
thirtytwobits
added a commit
to thirtytwobits/nunavut
that referenced
this issue
Nov 26, 2019
Major refactor of language context to drive filter options from configuration. The ability to modify things like stropping and encoding were fundamentally broken before this change. This work was done in support of adding named types as a concept to languages. This will allow generation of serialization code that is more configurable and will avoid fixing decisions like the use of size_t into templates instead moving these decisions into user-overridable configuration.
thirtytwobits
added a commit
to thirtytwobits/nunavut
that referenced
this issue
Nov 26, 2019
Major refactor of language context to drive filter options from configuration. The ability to modify things like stropping and encoding were fundamentally broken before this change. This work was done in support of adding named types as a concept to languages. This will allow generation of serialization code that is more configurable and will avoid fixing decisions like the use of size_t into templates instead moving these decisions into user-overridable configuration.
thirtytwobits
added a commit
to thirtytwobits/nunavut
that referenced
this issue
Nov 26, 2019
Major refactor of language context to drive filter options from configuration. The ability to modify things like stropping and encoding were fundamentally broken before this change. This work was done in support of adding named types as a concept to languages. This will allow generation of serialization code that is more configurable and will avoid fixing decisions like the use of size_t into templates instead moving these decisions into user-overridable configuration.
thirtytwobits
added a commit
to thirtytwobits/nunavut
that referenced
this issue
Nov 26, 2019
Major refactor of language context to drive filter options from configuration. The ability to modify things like stropping and encoding were fundamentally broken before this change. This work was done in support of adding named types as a concept to languages. This will allow generation of serialization code that is more configurable and will avoid fixing decisions like the use of size_t into templates instead moving these decisions into user-overridable configuration.
thirtytwobits
added a commit
to thirtytwobits/nunavut
that referenced
this issue
Nov 26, 2019
Major refactor of language context to drive filter options from configuration. The ability to modify things like stropping and encoding were fundamentally broken before this change. This work was done in support of adding named types as a concept to languages. This will allow generation of serialization code that is more configurable and will avoid fixing decisions like the use of size_t into templates instead moving these decisions into user-overridable configuration.
thirtytwobits
added a commit
to thirtytwobits/nunavut
that referenced
this issue
Nov 27, 2019
Major refactor of language context to drive filter options from configuration. The ability to modify things like stropping and encoding were fundamentally broken before this change. This work was done in support of adding named types as a concept to languages. This will allow generation of serialization code that is more configurable and will avoid fixing decisions like the use of size_t into templates instead moving these decisions into user-overridable configuration.
thirtytwobits
added a commit
to thirtytwobits/nunavut
that referenced
this issue
Nov 27, 2019
Major refactor of language context to drive filter options from configuration. The ability to modify things like stropping and encoding were fundamentally broken before this change. This work was done in support of adding named types as a concept to languages. This will allow generation of serialization code that is more configurable and will avoid fixing decisions like the use of size_t into templates instead moving these decisions into user-overridable configuration.
thirtytwobits
added a commit
that referenced
this issue
Dec 13, 2019
* Issue #94 and progress on Issue #91 Major refactor of language context to drive filter options from configuration. The ability to modify things like stropping and encoding were fundamentally broken before this change. This work was done in support of adding named types as a concept to languages. This will allow generation of serialization code that is more configurable and will avoid fixing decisions like the use of size_t into templates instead moving these decisions into user-overridable configuration. * updates per PR review comments
|
I need to check but I may have inadvertently fixed this issue already. |
|
Yep. This happened. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The 'ZX' and '_' prefix/suffix stropping/encoding arguments in filters are not fully plumbed through, would cause a lot of extra noise if they were, and aren't useful to have differ between filters. We should remove any filter arguments that specify these and provides them as part of the language context instead.
The text was updated successfully, but these errors were encountered: