Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend reg.drone.physics.kinematics with 3D geometry and define the GNSS service #100

Merged
merged 18 commits into from
Jan 17, 2021
Merged

Extend reg.drone.physics.kinematics with 3D geometry and define the GNSS service #100

merged 18 commits into from
Jan 17, 2021

Conversation

pavel-kirienko
Copy link
Member

@pavel-kirienko pavel-kirienko commented Jan 8, 2021 •
edited
Loading

This PR incorporates and supersedes #97 and unblocks https://github.com/107-systems/UAVCAN-GNSS-Node/issues/2. @aentinger please review.

Start here:

  • reg/drone/physics/kinematics/README.md
  • reg/drone/service/gnss/_.0.1.uavcan

@pavel-kirienko pavel-kirienko self-assigned this Jan 8, 2021
@pavel-kirienko pavel-kirienko mentioned this pull request Jan 8, 2021
Closed
Base automatically changed from subject-naming to master January 8, 2021 20:08
pavel-kirienko and others added 17 commits January 11, 2021 12:57
@pavel-kirienko
Minor change: remove unnecessary commentary to avoid misdirection and…
862c057 
… use consistent field naming
@pavel-kirienko
Add notes to reg.drone.physics regarding the application-layer conven…
97b7805 
…tions
@pavel-kirienko
Add Pose and Twist types
3530f2c
@pavel-kirienko
Add the combined SecondOrder kinetic state
832ce20
@pavel-kirienko
Remove the header comment check because it is not useful
edfef36
@pavel-kirienko
Correct errors
5965626
@pavel-kirienko
Use a cleaner name for kinematic state types: just 'State'
c3faf03
@pavel-kirienko
Clean up the verification script
9e4b7b7
@pavel-kirienko
Restructure the kinematics namespace and support spherical coordinates
e5c0520
@aentinger @pavel-kirienko
Very rough first draft of GNSS sensor device description.
9ba07ba
@pavel-kirienko
Relocate Alexander's types
3ab396f
@pavel-kirienko
Add time models
25a17c9
@pavel-kirienko
Add auxiliary types for the GNSS service
9421b61
@pavel-kirienko
Define service contracts
6404cc0
@pavel-kirienko
Replace 'vo' with 'visual_odometry'
05a51ba
@pavel-kirienko
Speculative change ahead of Alexander's review: replace FixStatus wit…
6cbda65 
…h a simple boolean flag.

See PR discussion.
@pavel-kirienko
Extend Sources with UWB and spread the reserved space
72ff444
@pavel-kirienko
Copy link
Member Author

I just noticed that I forgot to rebase this changeset back to master after the dependent branch was merged in #98. Fixed now.

@pavel-kirienko pavel-kirienko marked this pull request as ready for review January 11, 2021 10:59
@pavel-kirienko
Copy link
Member Author

@aentinger can you please either approve this or introduce further suggestions?

@pavel-kirienko pavel-kirienko mentioned this pull request Jan 17, 2021
Merged
@pavel-kirienko pavel-kirienko merged commit 8ee6e6e into master Jan 17, 2021
@pavel-kirienko pavel-kirienko deleted the 3d-geometry branch January 17, 2021 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aentinger aentinger aentinger approved these changes

@dagar dagar Awaiting requested review from dagar

@Igor-Misic Igor-Misic Awaiting requested review from Igor-Misic

@PetervdPerk-NXP PetervdPerk-NXP Awaiting requested review from PetervdPerk-NXP

@thirtytwobits thirtytwobits Awaiting requested review from thirtytwobits

Assignees

@pavel-kirienko pavel-kirienko

Labels
new-data-type
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pavel-kirienko @aentinger