Turned on CRC16 and CRC32 Computation #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now CRC16-CCITT-FALSE and CRC32-C (for single packets) mismatch will now show Expert Info.
|
@pavel-kirienko : can you take a look? |
pavel-kirienko
approved these changes
Jun 22, 2023
There was a problem hiding this comment.
I am not very proficient with moonspeak and Wireshark, so the utility of my review is limited. Protocol-wise, I don't see any shortcomings so far (except for the lack of CRC check for multi-frame transfers, but this has already been discussed).
I think this module could use some tests, at least to validate the CRC implementations. Reference inputs and outputs are given in the Cyphal spec in the annex; you've probably seen that.
Co-authored-by: Pavel Kirienko <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now CRC16-CCITT-FALSE and CRC32-C (for single packets) mismatch will
now show Expert Info.