Add CRC32 at the end of a transfer and demark the payload as a field #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #5 Added Payload size too and fixed names for CRC.
thirtytwobits
approved these changes
Jun 8, 2023
There was a problem hiding this comment.
You'd have to help me with the APIs for my review to be really worth-while but as long as this matches the specification (https://opencyphal.org/specification/Cyphal_Specification.pdf) then we're good.
There was a problem hiding this comment.
The version is only 4 bits. The following 4 bits are reserved.
| @@ -23,7 +23,10 @@ frame_index_eot = ProtoField.uint32("cyphal_udp.frame_index_eot", "frame_index_e | |||
| frame_index = ProtoField.uint32("cyphal_udp.frame_index", "frame_index", base.DEC) | |||
| end_of_transfer = ProtoField.bool("cyphal_udp.end_of_transfer", "end_of_transfer", base.NONE) | |||
| user_data = ProtoField.uint16("cyphal_udp.user_data", "user_data", base.HEX) | |||
| crc16_ccitt_false = ProtoField.uint16("cyphal_udp.crc16_ccitt_false", "crc16_ccitt_false (BE)", base.HEX) | |||
| crc16_ccitt_false = ProtoField.uint16("cyphal_udp.crc16_ccitt_false", "CRC16-CCITT-FALSE (BE)", base.HEX) | |||
There was a problem hiding this comment.
It's all upper-case now. Okay. Am I supposed to be impressed?
There was a problem hiding this comment.
All the reference online are in SHOUTY CASE. So I thought I'd SHOUT too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5
Added Payload size too and fixed names for CRC.