GoodWe ET write implementation #1077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
*Removed unnecessary registers. *Changed access types and priorities for few registers.
sfeilmeier
changed the title
sfeilmeier
approved these changes
Mar 13, 2020
sfeilmeier
reviewed
Apr 30, 2020
| @AttributeDefinition(name = "Modbus Unit-id", description = "Unit-id") | ||
| int unit_id() default GoodWeEtConstants.DEFAULT_UNIT_ID; | ||
|
|
||
| @AttributeDefinition(name = "Power Mode", description = "Mode of the power") | ||
| PowerModeEms Powermode() default PowerModeEms.AUTO; |
There was a problem hiding this comment.
@venu-sagar I see that this config setting is not used anywhere. Also from the description it is not clear what it is supposed to be. Can we remove it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added apply power implementation
- adjusted according to different power modes based on the availability of PV.
Added Allowed charge/Discharge based on Max apparent power
Added Energy value registers (Production, consumption, grid buy and grid sell)
- a slight adjustment in the SUM implementation file (Energy values handler).