Add compatibility with old BYD Battery-Box Commercial C130 hardware #1353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- dynamically add registers for "ModuleQty", "TotalVoltageOfSingleModule", "ChargeMaxVoltage" and "DischargeMinVoltage" only if they are available - for old hardware use default values "820 V" for ChargeMaxVoltage and "638 V" for DischargeMinVoltage - general cleanup: move enums to separate package - move readElementsOnce()-method to new "ModbusUtils" class - update Sunspec and Socomec implementations to use new ModbusUtils - remove unused ClusterRunState
|
@ludwigasen and @huseyinsaht: FYI |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dynamically add registers for "ModuleQty", "TotalVoltageOfSingleModule", "ChargeMaxVoltage" and "DischargeMinVoltage" only if they are available
for old hardware use default values "820 V" for ChargeMaxVoltage and "638 V" for DischargeMinVoltage
general cleanup: move enums to separate package
move readElementsOnce()-method to new "ModbusUtils" class
update Sunspec and Socomec implementations to use new ModbusUtils
remove unused ClusterRunState