-
Notifications
You must be signed in to change notification settings - Fork 419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
App Manager #1860
Merged
Merged
App Manager #1860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Reworked validation for IP-Addresses. Now it is enought if the Edge has an IP in the same network. - Added Worker for installing free Apps - Fixed deleting Component IDs in Scheduler - Fixed validation for IPs. e. g. Keba needs the IP '192.168.25.10' to access the EVCS '192.168.25.11' but if the EVCS doesnt start with '192.168.25.' it does not get added. - Fixed NullPointer if an App Name gets refactored and the app instance appid cant be mapped to an actual app - Added GridServingLoading, ManualRelayControl, ThresholdControl Apps
sfeilmeier
approved these changes
Jun 21, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Impressive set of changes. I did not follow everything in detail, but all the new concepts (e.g. App dependencies) look very good.
io.openems.edge.core/src/io/openems/edge/core/appmanager/AbstractOpenemsApp.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to AppManager/AppCenter