Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEMS Backport #2419

Merged
merged 11 commits into from
Nov 1, 2023
Merged

FEMS Backport #2419

merged 11 commits into from
Nov 1, 2023

Conversation

sfeilmeier
Copy link
Contributor

@sfeilmeier sfeilmeier commented Nov 1, 2023

  • KACO PV-Inverter: calculate production energy manually
  • GoodWe 20/30 Chargers: avoid multiple HIGH Priority mobus tasks
  • UI: Utils, tests and translations
  • UI: Fix chart wrong scaling when firstSetupProtocol is too close to...
  • Backport FEMS Backend
    • Fix compatibility with and require Odoo 16 (separate Odoo module will be updated independently)
    • Fix possible NPEs
    • Fix starting of Websocket servers (avoid event race conditions)
    • Add COMPONENT_IDs to backend components
    • Fix Websocket handshake case-insensitive
    • Improve general performance
    • Avoid excessive logs
    • Add GenericSystemLog to Metadata: record system execute and update
    • Improve InfluxDB Aggregated data handling
    • Allow multiple InfluxDB servers for different periods (defined by start-/enddate)
    • InfluxDB: only allow Channel-Addresses in standardized format
  • Websocket Api Controller: cleanup getEdgeRequest & JUnit tests
  • AppCenter: add check for peakshaving to not be compatible with home
  • AppCenter: separated AppConfiguration into tasks
  • Update Gitpod to Odoo v16 for https://github.com/OpenEMS/odoo-openems/tree/16.0

sfeilmeier and others added 11 commits November 1, 2023 13:43
Sometimes data from SunSpec was not reliable (even after fixing SunSpec scalefactors).

Reviewed-by: Hueseyin Sahutoglu <[email protected]>
Reviewed-by: Stefan Feilmeier <[email protected]>
Co-authored-by: Michael Grill <[email protected]>
Set goodwe charger channels by the abstract goodwe component to avoid multiple HIGH Priority mobus tasks for Goodwe20/30 Chargers.

TwoStringCharger is no longer a ModbusComponent

Reviewed-by: Michael Grill <[email protected]>
Reviewed-by: Stefan Feilmeier <[email protected]>
Co-authored-by: Sebastian Asen <[email protected]>
* fix subtractSafely of not checking for undefined
   * explicitely checking for undefined and null
   * add unittest for utils

Reviewed-by: Stefan Feilmeier <[email protected]>
Co-authored-by: Lukas Rieger <[email protected]>
…nd of month

Reviewed-by: Stefan Feilmeier <[email protected]>
Co-authored-by: Lukas Rieger <[email protected]>
- Fix compatibility with and require Odoo 16 (separate Odoo module will be updated independently)
- Fix possible NPEs
- Fix starting of Websocket servers (avoid event race conditions)
- Add COMPONENT_IDs to backend components
- Fix Websocket handshake case-insensitive
- Improve general performance
- AVoid excessive logs
- Add GenericSystemLog to Metadata: record system execute and update
- Improve InfluxDB Aggregated data handling
- Allow multiple InfluxDB servers for different periods (defined by start-/enddate)
- InfluxDB: only allow Channel-Addresses in standardized format

Co-authored-by: Michael Grill <[email protected]>
Co-authored-by: Stefan Feilmeier <[email protected]>
* Cleanup getEdgeRequest to use the static method to generate the metadata for the local edge
 * added tests for getEdgeRequest/getEdgesRequest  Edge

Reviewed-by: Hueseyin Sahutoglu <[email protected]>
Reviewed-by: Stefan Feilmeier <[email protected]>
Co-authored-by: Michael Grill <[email protected]>
- added invert boolean for error messages
- add test for peakshaving & CheckHome
- update translations

Reviewed-by: Hueseyin Sahutoglu <[email protected]>
Reviewed-by: Stefan Feilmeier <[email protected]>
Co-authored-by: Michael Grill <[email protected]>
This change is a prerequisite for automatically adding channels to the persistence predictor for TimeOfUseTariff Apps.

 - separated AppConfiguration into tasks
 - added Builder for AppConfiguration
 - changed AppConfiguration to a record
 - moved AggregateTasks into separate folder
 - added simple(& automatical) order for tasks
 - add tests for all AggregateTasks
 - moved validation to AggregateTasks to validate their Task configuration
 - changed AppValidateWorker to a (OSGi-)Component
 - added OnlyIfThrowing interface

Reviewed-by: Hueseyin Sahutoglu <[email protected]>
Reviewed-by: Stefan Feilmeier <[email protected]>
Co-authored-by: Michael Grill <[email protected]>
Copy link

github-actions bot commented Nov 1, 2023

Code Coverage

@sfeilmeier sfeilmeier merged commit 1e95d4d into develop Nov 1, 2023
2 checks passed
@sfeilmeier sfeilmeier deleted the feature/fems-backport branch November 1, 2023 15:42
Copy link

github-actions bot commented Nov 1, 2023

Code Coverage

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant