Implement ShellyPlus1PM #2571
Merged
Implement ShellyPlus1PM #2571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
|
|
|
|
|
|
|
sfeilmeier
requested changes
Jun 1, 2024
io.openems.edge.io.shelly/src/io/openems/edge/io/shelly/shellyplus1pm/IoShellyPlus1PmImpl.java
Outdated
Show resolved
Hide resolved
|
@sfeilmeier ist erledigt, danke für den Hinweis ! :) |
|
|
|
|
|
|
|
|
sfeilmeier
approved these changes
Jun 19, 2024
| private SinglePhase phase = null; | ||
| private String baseUrl; | ||
|
|
||
| private volatile Timedata timedata; |
There was a problem hiding this comment.
Missing @reference. This is always null.
|
|
||
| @Override | ||
| public String debugLog() { | ||
| var b = new StringBuilder(); |
There was a problem hiding this comment.
Can use Utils.generateDebugLog(this.getRelayChannel(), this.getActivePowerChannel())
| if (this.phase != null) { | ||
| switch (this.phase) { | ||
| case L1: | ||
| this._setActivePowerL1(power); |
There was a problem hiding this comment.
No... we had discussed this for IO.Shelly.Plus.PlugS
| this.logDebug(this.log, e.getMessage()); | ||
| } | ||
|
|
||
| this._setRelay(relay0); |
There was a problem hiding this comment.
This must be outside the brackets.
| public void test() throws Exception { | ||
| new ComponentTest(new IoShellyPlus1PmImpl()) // | ||
| .addReference("httpBridgeFactory", DummyBridgeHttpFactory.ofDummyBridge()) // | ||
| .activate(MyConfig.create() // |
There was a problem hiding this comment.
Please provide full JUnit test, including parsing the JSON response
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example JSON:
{"ble":{},"cloud":{"connected":true},"input:0":{"id":0,"state":false},"mqtt":{"connected":false},"switch:0":{"id":0, "source":"init", "output":false, "apower":0.0, "voltage":231.3, "current":0.000, "aenergy":{"total":8629.000,"by_minute":[0.000,0.000,0.000],"minute_ts":1708858380},"temperature":{"tC":44.3, "tF":111.7}},"sys":{"mac":"80646FE34998","restart_required":false,"time":"11:53","unixtime":1708858386,"uptime":150390,"ram_size":260364,"ram_free":115308,"fs_size":458752,"fs_free":143360,"cfg_rev":22,"kvs_rev":2,"schedule_rev":0,"webhook_rev":0,"available_updates":{},"reset_reason":3},"wifi":{"sta_ip":"192.168.178.169","status":"got ip","ssid":"heizung","rssi":-48,"ap_client_count":0},"ws":{"connected":false}}