ENTSO-E: fix parsing of XML, resolution fallback, improve error handling #2839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Summary of Changes This pull request introduces a fix to the `TouEntsoeImpl` class in the `io.openems.edge.timeofusetariff.entsoe` package. The changes are specifically aimed at resolving the issue where the ENTSO-E API is not returning any values for Belgium when using the PT60M resolution. ### Key Improvements 1. **Fallback to PT15M Resolution**: - Added logic to attempt a fallback to the PT15M resolution if the primary query for PT60M fails. This ensures that pricing data can still be retrieved when PT60M is unavailable. - Improved error handling and logging to provide clear visibility into the fallback process. 2. **Error Logging**: - Enhanced logging to capture exceptions that occur during the retrieval of pricing data. This includes detailed logs for both PT60M and PT15M queries, allowing for easier debugging and tracking of issues. ## Impact These changes address the specific issue reported in [OpenEMS#2830](OpenEMS#2830) by providing a robust mechanism to handle cases where the PT60M resolution is no longer available. This will improve the user experience for those configuring TimeOfUse Tariffs in Belgium and ensure that data can still be accessed. ## Related Issues - Fixes [OpenEMS#2830](OpenEMS#2830): Entso-e tariffs for Belgium not loaded - No data for resolution: PT60M.
Codecov ReportAttention: Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #2839 +/- ##
=============================================
+ Coverage 56.55% 56.66% +0.12%
- Complexity 8888 8926 +38
=============================================
Files 2167 2167
Lines 91918 91959 +41
Branches 6834 6831 -3
=============================================
+ Hits 51973 52101 +128
+ Misses 38086 37982 -104
- Partials 1859 1876 +17 |
- automatically choose smallest resolution of available data - handle exceptions internally - handle missing values and multiple periods - add additional tests for real XML
|
@Sn0w3y: I hijacked your PR and backported some changes I have recently been applying for ENTSO-E for FEMS. |
sfeilmeier
changed the title
sfeilmeier
approved these changes
Oct 25, 2024
haha, no Problem ! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This pull request introduces a fix to the
TouEntsoeImplclass in theio.openems.edge.timeofusetariff.entsoepackage. The changes are specifically aimed at resolving the issue where the ENTSO-E API is not returning any values for Belgium when using the PT60M resolution.Key Improvements
Fallback to PT15M Resolution:
Error Logging:
Impact
These changes address the specific issue reported in #2830 by providing a robust mechanism to handle cases where the PT60M resolution is no longer available. This will improve the user experience for those configuring TimeOfUse Tariffs in Belgium and ensure that data can still be accessed.
Related Issues