FEMS Backports 2024-10 (2) #2846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- extend UI-README - remove all references to `Time-of-use Beta Test` Reviewed-by: Stefan Feilmeier <[email protected]> Co-authored-by: Lukas Rieger <[email protected]> Co-committed-by: Lukas Rieger <[email protected]>
- Implemented BridgeHttp in Impl of HardyBarthEvcs - All Api Calls now flow through that Bridge - Api Calls (esp. setHeartBeat that previously was synchronous) are now asynchronous - Add JUnit tests Co-authored-by: Sebastian Asen <[email protected]> Co-authored-by: Stefan Feilmeier <[email protected]> Reviewed-by: Michael Grill <[email protected]> Reviewed-by: Stefan Feilmeier <[email protected]> Co-authored-by: Johann Kaufmann <[email protected]> Co-committed-by: Johann Kaufmann <[email protected]>
- Navigation for users with at most Role `OWNER` with one fems assigned, get directly routed to `device/edgeId/live` - Navigation for users with at least Role `INSTALLER` -> `/overview` - Removed flickering of headerComponent. Issue results from creating header component for each view Co-authored-by: Stefan Feilmeier <[email protected]> Reviewed-by: Anas Shetla <[email protected]> Reviewed-by: Stefan Feilmeier <[email protected]> Co-authored-by: Lukas Rieger <[email protected]> Co-committed-by: Lukas Rieger <[email protected]>
- Migrate all EVCS to ElectricityMeter Nature - Add `DeprecatedEvcs` Nature to mark EVCS that have to be migrated and still support old Channels ChargePower and ActiveConsumptionEnergy - Implement generic `evaluatePhaseCount()` method - UI: Mix Evcs & ElectricityMeter (live != history) - Live: use ElectricityMeter if its already available (e.g. for power of individual phases) - History: use Evcs to ensure availability of historic data - Implement configurable PhaseRotation in configuration and Apps (copied and adjusted from https://github.com/OpenEMS/openems/blob/f73c2376e80fc0b820e5864e2ea6f83467c9aa87/io.openems.edge.evcs.api/src/io/openems/edge/evcs/v2/api/PhaseRotation.java) - Fix AbstractManagedEvcs deactivate() Reviewed-by: Sebastian Asen <[email protected]>
https://github.com/gradle/gradle/releases/tag/v8.10.2 (cherry picked from commit 14131763b8dd9bd58cafd683abe7641303f1a627)
- Refactoring HeatingElement and using the new ```Cumulated[Level 1 -3]ActiveTime``` Co-authored-by: Sebastian Asen <[email protected]> Reviewed-by: Sebastian Asen <[email protected]> Reviewed-by: Stefan Feilmeier <[email protected]> Co-authored-by: Lukas Rieger <[email protected]> Co-committed-by: Lukas Rieger <[email protected]>
- Multiple yAxis: Increase chart canvas by putting y axis labels into ticks, the most upper tick gets replaced by axis title Reviewed-by: Stefan Feilmeier <[email protected]> Co-authored-by: Lukas Rieger <[email protected]> Co-committed-by: Lukas Rieger <[email protected]>
- Added detailed data for the excel export of historic data Co-authored-by: Sebastian Asen <[email protected]> Reviewed-by: Sebastian Asen <[email protected]> Reviewed-by: Michael Grill <[email protected]> Reviewed-by: Stefan Feilmeier <[email protected]> Co-authored-by: Johann Kaufmann <[email protected]> Co-committed-by: Johann Kaufmann <[email protected]>
…charts - Rescaling of charts was not possible due to not ignoring hidden values - Header was shown in the chart views Reviewed-by: Stefan Feilmeier <[email protected]> Co-authored-by: Lukas Rieger <[email protected]> Co-committed-by: Lukas Rieger <[email protected]>
Reviewed-by: Stefan Feilmeier <[email protected]> Co-authored-by: Sebastian Asen <[email protected]> Co-committed-by: Sebastian Asen <[email protected]>
- Introduce `<app-header>` and keep `<header>` as single navigation point header Reviewed-by: Stefan Feilmeier <[email protected]> Co-authored-by: Lukas Rieger <[email protected]> Co-committed-by: Lukas Rieger <[email protected]>
…ters Evcs were listed with meters not with charging stations Reviewed-by: Stefan Feilmeier <[email protected]> Co-authored-by: Lukas Rieger <[email protected]> Co-committed-by: Lukas Rieger <[email protected]>
- Improve OpenEMS JUnit test framework - Apply best practices to JUnit tests
- Because of the recent change that all evcs now inherit the nature "elecricitymeter" they now appear twice in the excel list, because both natures are checked for - Removed check for "evcs" nature so charging stations only appear once Co-authored-by: Sebastian Asen <[email protected]> Reviewed-by: Stefan Feilmeier <[email protected]> Co-authored-by: Johann Kaufmann <[email protected]> Co-committed-by: Johann Kaufmann <[email protected]>
Codecov ReportAttention: Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #2846 +/- ##
=============================================
+ Coverage 56.11% 56.39% +0.29%
- Complexity 8545 8665 +120
=============================================
Files 2140 2147 +7
Lines 90538 90682 +144
Branches 6717 6746 +29
=============================================
+ Hits 50795 51134 +339
+ Misses 37985 37721 -264
- Partials 1758 1827 +69 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EVCS HardyBarth: communicate via HTTP-Bridge
EVCS: implement ElectricityMeter
DeprecatedEvcsNature to mark EVCS that have to be migrated and still support old Channels ChargePower and ActiveConsumptionEnergyevaluatePhaseCount()methodUI: Performance improvements
OWNERwith one fems assigned, get directly routed todevice/edgeId/liveINSTALLER->/overviewSum: do not ignore ExtremeEverValues in EdgeConfig
Update gradle to 8.10.2
UI: Refactor heating element history
Cumulated[Level 1 -3]ActiveTimeUI: Adjust Chart-axis generation
Extend export to Excel file
UI: fix header in history charts and add enable rescaling in history charts
<app-header>and keep<header>as single navigation point headerJava JUnit tests: improve framework + cleanup
Co-authored-by: Lukas Rieger [email protected]
Co-authored-by: Sebastian Asen [email protected]
Co-authored-by: Stefan Feilmeier [email protected]
Co-authored-by: Johann Kaufmann [email protected]