-
Notifications
You must be signed in to change notification settings - Fork 412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added self consumption controller and predictive delay charge control… #911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # io.openems.edge.application/EdgeApp.bndrun
…ich is not the value of that particular hour. changed it to the hourly data.
# Conflicts: # io.openems.edge.application/EdgeApp.bndrun
sfeilmeier
requested changes
Nov 20, 2019
io.openems.edge.controller.ess.predictivedelaycharge/readme.adoc
Outdated
Show resolved
Hide resolved
.../src/io/openems/edge/controller/ess/predictivedelaycharge/AbstractPredictiveDelayCharge.java
Outdated
Show resolved
Hide resolved
this.clock = clock; | ||
} | ||
|
||
public void run(Integer[] production, Integer[] consumption, LocalDateTime starthour) throws OpenemsNamedException { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do this calculation inside of getCalculatedPower() method. This avoids having to store a class variable "calculatedPower"
.../src/io/openems/edge/controller/ess/predictivedelaycharge/AbstractPredictiveDelayCharge.java
Outdated
Show resolved
Hide resolved
...redictivedelaycharge/src/io/openems/edge/controller/ess/predictivedelaycharge/ac/Config.java
Outdated
Show resolved
Hide resolved
...redictivedelaycharge/src/io/openems/edge/controller/ess/predictivedelaycharge/ac/Config.java
Outdated
Show resolved
Hide resolved
...redictivedelaycharge/src/io/openems/edge/controller/ess/predictivedelaycharge/ac/Config.java
Outdated
Show resolved
Hide resolved
io.openems.edge.controller.symmetric.selfconsumption/readme.adoc
Outdated
Show resolved
Hide resolved
...elfconsumption/src/io/openems/edge/controller/symmetric/selfconsumption/SelfConsumption.java
Outdated
Show resolved
Hide resolved
…ving extra getters and adjusting the position of setting the channel values
…penEMS/openems into feature/SelfConsumptionACandDC # Conflicts: # io.openems.edge.application/EdgeApp.bndrun
# Conflicts: # io.openems.edge.application/EdgeApp.bndrun
sfeilmeier
approved these changes
Dec 13, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done!
sebastianasen
added a commit
that referenced
this pull request
Jan 8, 2020
…openems into feature/evcs_ocppserver * 'feature/evcs_ocppserver' of https://github.com/OpenEMS/openems: (55 commits) Start development of version 2020.2.0-SNAPSHOT Push version to 2020.1.0 UI: General Adjustments (#1029) Add no of cycles option to influxdb module. (#1028) OneWire.Thermometer: remove unnecessary event handler property Update bndrun files Fix setting Session-ID from Odoo Improve error handling for JSON-RPC Error Response Update UI dependencies Start development of 2019.19.0-SNAPSHOT Push version to 2019.18.0 Add 'resolution' to QueryHistoricTimeseriesDataRequest Resolve BackendApp.bndrun Update UI dependencies Add Controllers for Predictive Delay Charge and ESS Sell-To-Grid Limit (for 70 % restriction) (#911) UI: improvements to formly and history SoC chart (#1027) Add Schneider Acti9 Smartlink Electricity Meter (#1014) Repair Checkstyle XML definition Add Thermometer-API, OneWire bridge and OneWire-Thermometer implementation (#891) Update Java dependencies #1023 #1021 #1015 ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Self consumption controller.
Added Predictive delay charge controller.
Made a slight change in the order of alias, id on Production, consumption predictor.
Made a minor change to remove a couple of warnings in BYD container(Asked Pooran before using it.)