Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle local type definitions in Monaco #2883

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

josephjclark
Copy link
Contributor

Description

This PR enables local typedefs to be loaded when LOCAL_ADAPTORS=true

I told Frank not to worry about this and then SUDDENLY I need it today.

By default the monaco code assist and adaptor docs will both call out to unpkg for types. Not ideal if you're trying to test typedefs in a local adaptor build.

This is a super PR which roughs in support to fetch typedefs from the monorepo using a proxy server

Actually, at the moment I'm using npx serve --cors -l 5000 from inside adaptors to create a local server. I'll need help to setup a proxy inside Lightning.

TODO

  • Fix adaptor docs
  • Tidy implementation
  • Setup a proxy server in lightning which serves from the monorepo

AI Usage

Please disclose how you've used AI in this work (it's cool, we just want to know!):

  • Code generation (copilot but not intellisense)
  • Learning or fact checking
  • Strategy / design
  • Optimisation / refactoring
  • Translation / spellchecking / doc gen
  • Other
  • [x I have not used AI

You can read more details in our Responsible AI Policy

Pre-submission checklist

  • I have performed a self-review of my code.
  • I have implemented and tested all related authorization policies. (e.g., :owner, :admin, :editor, :viewer)
  • I have updated the changelog.
  • I have ticked a box in "AI usage" in this PR

@josephjclark josephjclark self-assigned this Jan 30, 2025
Copy link

codecov bot commented Jan 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.44%. Comparing base (3c438ea) to head (8bda767).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2883   +/-   ##
=======================================
  Coverage   91.44%   91.44%           
=======================================
  Files         343      343           
  Lines       12351    12351           
=======================================
  Hits        11294    11294           
  Misses       1057     1057           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: New Issues
Development

Successfully merging this pull request may close these issues.

1 participant